Skip to content

Commit 9205c42

Browse files
committed
DPL GUI: introduce namespace gui for getGUIDebugger
1 parent 35131aa commit 9205c42

File tree

4 files changed

+12
-4
lines changed

4 files changed

+12
-4
lines changed

Framework/Core/include/Framework/FrameworkGUIDebugger.h

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,10 +26,13 @@ namespace framework
2626
class DriverInfo;
2727
class DriverControl;
2828

29+
namespace gui
30+
{
2931
std::function<void(void)> getGUIDebugger(const std::vector<DeviceInfo>& infos, const std::vector<DeviceSpec>& devices,
3032
const std::vector<DeviceMetricsInfo>& metricsInfos,
3133
const DriverInfo& driverInfo, std::vector<DeviceControl>& controls,
3234
DriverControl& driverControl);
35+
} // namespace gui
3336
} // namespace framework
3437
} // namespace o2
3538
#endif // FRAMEWORK_FRAMEWORKGUIDEBUGGER_H

Framework/Core/src/FrameworkDummyDebugger.cxx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,8 @@ namespace o2
1515
{
1616
namespace framework
1717
{
18-
18+
namespace gui
19+
{
1920
// Dummy function in case we want to build without debugger.
2021
std::function<void(void)> getGUIDebugger(const std::vector<DeviceInfo>& infos, const std::vector<DeviceSpec>& devices,
2122
const std::vector<DeviceMetricsInfo>& metricsInfos,
@@ -27,5 +28,6 @@ std::function<void(void)> getGUIDebugger(const std::vector<DeviceInfo>& infos, c
2728

2829
void showNodeGraph(bool* opened) {}
2930

31+
} // namespace gui
3032
} // namespace framework
3133
} // namespace o2

Framework/Core/src/FrameworkGUIDebugger.cxx

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,8 @@ namespace o2
3131
{
3232
namespace framework
3333
{
34+
namespace gui
35+
{
3436
// Type erased information for the plotting
3537
struct MultiplotData {
3638
int mod;
@@ -41,10 +43,11 @@ struct MultiplotData {
4143
MetricType type;
4244
};
4345

46+
} // namespace gui
4447
} // namespace framework
4548
} // namespace o2
4649

47-
template class std::vector<o2::framework::MultiplotData>;
50+
template class std::vector<o2::framework::gui::MultiplotData>;
4851

4952
namespace o2
5053
{

Framework/Core/src/runDataProcessing.cxx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -721,7 +721,7 @@ int runStateMachine(DataProcessorSpecs const& workflow, DriverControl& driverCon
721721
auto resourceManager = std::make_unique<SimpleResourceManager>(driverInfo.startPort, driverInfo.portRange);
722722

723723
void* window = nullptr;
724-
decltype(getGUIDebugger(infos, deviceSpecs, metricsInfos, driverInfo, controls, driverControl)) debugGUICallback;
724+
decltype(gui::getGUIDebugger(infos, deviceSpecs, metricsInfos, driverInfo, controls, driverControl)) debugGUICallback;
725725

726726
// An empty frameworkId means this is the driver, so we initialise the GUI
727727
if (driverInfo.batch == false && frameworkId.empty()) {
@@ -823,7 +823,7 @@ int runStateMachine(DataProcessorSpecs const& workflow, DriverControl& driverCon
823823
// We need to recreate the GUI callback every time we reschedule
824824
// because getGUIDebugger actually recreates the GUI state.
825825
if (window) {
826-
debugGUICallback = getGUIDebugger(infos, deviceSpecs, metricsInfos, driverInfo, controls, driverControl);
826+
debugGUICallback = gui::getGUIDebugger(infos, deviceSpecs, metricsInfos, driverInfo, controls, driverControl);
827827
}
828828
break;
829829
case DriverState::SCHEDULE:

0 commit comments

Comments
 (0)