MFT XML segmentation (#1446)

* MFT Ladder segmentation on Detectors/ITSMFT/MFT/data/Geometry.xml

* First MFT chips placed independently

* New origin for ladders in disk0

* Fixed correction for MFT sensor positions

Author: rpezzi

Detectors/ITSMFT/MFT/base/include/MFTBase/LadderSegmentation.h

@@ -17,6 +17,7 @@
 #define ALICEO2_MFT_LADDERSEGMENTATION_H_
 
 #include "TClonesArray.h"
+#include "TXMLEngine.h"
 
 #include "MFTBase/VSegmentation.h"
 #include "MFTBase/ChipSegmentation.h"
@@ -52,7 +53,7 @@ class LadderSegmentation : public VSegmentation
 
   ChipSegmentation* getSensor(Int_t sensor) const;
 
-  void createSensors();
+  void createSensors(TXMLEngine* xml, XMLNodePointer_t node);
 
   /// \brief Returns number of Sensor on the ladder
   Int_t getNSensors() const { return mNSensors; };

Detectors/ITSMFT/MFT/base/src/ChipSegmentation.cxx

@@ -42,12 +42,12 @@ ChipSegmentation::ChipSegmentation(UInt_t uniqueID) : VSegmentation()
                mftGeom->getDiskID(GetUniqueID()), mftGeom->getLadderID(GetUniqueID()),
                mftGeom->getSensorID(GetUniqueID())));
 
-  Double_t pos[3];
-  pos[0] = mftGeom->getSensorID(GetUniqueID()) * (SegmentationAlpide::SensorSizeCols + Geometry::sSensorInterspace) +
-           Geometry::sSensorSideOffset;
-  pos[1] = Geometry::sSensorTopOffset;
-  pos[2] = Geometry::sFlexThickness;
-  setPosition(pos);
+  //  Double_t pos[3];
+  //  pos[0] = mftGeom->getSensorID(GetUniqueID())*
+  //    (SegmentationAlpide::SensorSizeCols + Geometry::sSensorInterspace) + Geometry::sSensorSideOffset;
+  //  pos[1] = Geometry::sSensorTopOffset;
+  //  pos[2] = Geometry::sFlexThickness;
+  //  setPosition(pos);
 }
 
 /// \brief Print out Sensor information (Name, ID, position, orientation)

Detectors/ITSMFT/MFT/base/src/HalfDiskSegmentation.cxx

@@ -142,19 +142,7 @@ void HalfDiskSegmentation::createLadders(TXMLEngine* xml, XMLNodePointer_t node)
     ladder->setPosition(pos);
     ladder->setRotationAngles(ang);
 
-    /// @todo : In the XML geometry file, the position of the top-left corner of the chip closest to the pipe is given
-    /// in the Halfdisk coordinate system.
-    /// Need to put in the XML file the position of the ladder coordinate center
-    // Find the position of the corner of the flex which is the ladder corrdinate system center.
-
-    pos[0] = -Geometry::sSensorSideOffset;
-    pos[1] = -Geometry::sSensorTopOffset - SegmentationAlpide::SensorSizeRows;
-    pos[2] = -Geometry::sFlexThickness - Geometry::sChipThickness;
-    Double_t master[3];
-    ladder->getTransformation()->LocalToMaster(pos, master);
-    ladder->setPosition(master);
-
-    ladder->createSensors();
+    ladder->createSensors(xml, node);
 
     new ((*mLadders)[iladder]) LadderSegmentation(*ladder);
     delete ladder;

Detectors/ITSMFT/MFT/base/src/LadderSegmentation.cxx

@@ -64,26 +64,75 @@ LadderSegmentation::LadderSegmentation(const LadderSegmentation& ladder)
 /// Creates the Sensors Segmentation array on the Ladder
 
 //_____________________________________________________________________________
-void LadderSegmentation::createSensors()
+void LadderSegmentation::createSensors(TXMLEngine* xml, XMLNodePointer_t node)
 {
 
   if (!mChips) {
     mChips = new TClonesArray("o2::MFT::ChipSegmentation", mNSensors);
     mChips->SetOwner(kTRUE);
   }
 
-  Geometry* mftGeom = Geometry::instance();
-
-  for (Int_t iSensor = 0; iSensor < mNSensors; iSensor++) {
-    UInt_t sensorUniqueID =
-      mftGeom->getObjectID(Geometry::SensorType, mftGeom->getHalfID(GetUniqueID()), mftGeom->getDiskID(GetUniqueID()),
-                           mftGeom->getPlaneID(GetUniqueID()), mftGeom->getLadderID(GetUniqueID()), iSensor);
+  Int_t ichip;
+  Double_t pos[3];
+  Double_t ang[3] = { 0., 0., 0. };
 
-    auto* chip = new ChipSegmentation(sensorUniqueID);
+  Geometry* mftGeom = Geometry::instance();
 
-    new ((*mChips)[iSensor]) ChipSegmentation(*chip);
+  TString nodeName = xml->GetNodeName(node);
+  if (!nodeName.CompareTo("chip")) {
+    XMLAttrPointer_t attr = xml->GetFirstAttr(node);
+    while (attr != nullptr) {
+      TString attrName = xml->GetAttrName(attr);
+      TString attrVal = xml->GetAttrValue(attr);
+      if (!attrName.CompareTo("ichip")) {
+        ichip = attrVal.Atoi();
+        if (ichip >= getNSensors() || ichip < 0) {
+          LOG(FATAL) << "Wrong chip number : " << ichip << FairLogger::endl;
+        }
+      } else if (!attrName.CompareTo("xpos")) {
+        pos[0] = attrVal.Atof();
+      } else if (!attrName.CompareTo("ypos")) {
+        pos[1] = attrVal.Atof();
+      } else if (!attrName.CompareTo("zpos")) {
+        pos[2] = attrVal.Atof();
+      } else if (!attrName.CompareTo("phi")) {
+        ang[0] = attrVal.Atof();
+      } else if (!attrName.CompareTo("theta")) {
+        ang[1] = attrVal.Atof();
+      } else if (!attrName.CompareTo("psi")) {
+        ang[2] = attrVal.Atof();
+      } else {
+        LOG(ERROR) << "Unknwon Attribute name " << xml->GetAttrName(attr) << FairLogger::endl;
+      }
+      attr = xml->GetNextAttr(attr);
+    }
+
+    UInt_t chipUniqueID =
+      mftGeom->getObjectID(Geometry::SensorType,
+                           mftGeom->getHalfID(GetUniqueID()),
+                           mftGeom->getDiskID(GetUniqueID()),
+                           mftGeom->getPlaneID(GetUniqueID()),
+                           mftGeom->getLadderID(GetUniqueID()),
+                           ichip);
+
+    auto* chip = new ChipSegmentation(chipUniqueID);
+    //    pos[0] = mftGeom->getSensorID(GetUniqueID())*
+    //    (SegmentationAlpide::SensorSizeCols + Geometry::sSensorInterspace) + Geometry::sSensorSideOffset;
+    //    pos[1] = Geometry::sSensorTopOffset;
+    //    pos[2] = Geometry::sFlexThickness;
+    chip->setPosition(pos);
+    chip->setRotationAngles(ang);
+
+    new ((*mChips)[ichip]) ChipSegmentation(*chip);
     delete chip;
   }
+
+  // display all child nodes
+  XMLNodePointer_t child = xml->GetChild(node);
+  while (child != nullptr) {
+    createSensors(xml, child);
+    child = xml->GetNext(child);
+  }
 }
 
 /// Returns pointer to a sensor segmentation