Slightly improve handling of kwcall definition lookup failure#147
Merged
serenity4 merged 3 commits intoJuliaDebug:masterfrom Sep 21, 2025
Merged
Slightly improve handling of kwcall definition lookup failure#147serenity4 merged 3 commits intoJuliaDebug:masterfrom
kwcall definition lookup failure#147serenity4 merged 3 commits intoJuliaDebug:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #147 +/- ##
===========================================
+ Coverage 69.60% 89.10% +19.49%
===========================================
Files 3 3
Lines 408 413 +5
===========================================
+ Hits 284 368 +84
+ Misses 124 45 -79 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
Thanks! Would it be difficult to add a test? Assuming it now gives a less confusing error, could we, e.g., |
Collaborator
Author
|
Sure! I actually had one case in hand already when making that PR, don't know why I didn't think of adding it straight away :) |
timholy
approved these changes
Sep 20, 2025
Member
|
Any objections if I transfer this repo to JuliaDebug? Or some other org? |
Collaborator
Author
|
None at all! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As part of Cthulhu tests, I caught an error where we try to get the definition of
kwcallitself from https://github.com/JuliaLang/julia/blob/12f7bb52e5714c577189665a05606e3764f333cf/base/boot.jl#L366, and our handling fails thinking that it's a "wrapping"kwcall(and not an actual definition).I don't think we can support parsing that well, so I just disabled that particular test in Cthulhu, but the failure mode was a bit obscure: it complained in our check
T <: FunctionthatTmust be a type, and wasVararg, which this PR tries to make a bit clearer.A very minor improvement, but I thought it wouldn't hurt to improve things once I figured out the reason for the subtyping check failure.