Add support for local RNG seed in Haar measure matrix generation and reproducibility tests#92
Add support for local RNG seed in Haar measure matrix generation and reproducibility tests#92alfranmu wants to merge 1 commit intoJuliaMath:masterfrom
Conversation
…rgument) for generating Haar measure matrices, allowing reproducible results. - Updated test suite to include reproducibility checks for Haar measure matrices.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #92 +/- ##
==========================================
+ Coverage 39.80% 39.82% +0.02%
==========================================
Files 12 12
Lines 819 821 +2
==========================================
+ Hits 326 327 +1
- Misses 493 494 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Can you get the codecov up? |
|
Sure! I’ll work on adding some tests to increase coverage and push the changes soon. |
|
|
||
| """ | ||
| rand(W::Ginibre) | ||
| rand(rng::AbstractRNG, W::Ginibre) |
There was a problem hiding this comment.
| rand(rng::AbstractRNG, W::Ginibre) | |
| rand([rng::AbstractRNG,] W::Ginibre) |
| #TODO implement O(n^2) method | ||
| """ | ||
| rand(W::Haar, n::Int) | ||
| rand(rng::AbstractRNG, W::Haar, n::Int) |
There was a problem hiding this comment.
| rand(rng::AbstractRNG, W::Haar, n::Int) | |
| rand([rng::AbstractRNG,] W::Haar, n::Int) |
same here.
|
|
||
| end # testset | ||
|
|
||
|
|
There was a problem hiding this comment.
These extra lines below don't seem necessary.
|
|
||
| rand(W::Haar, n::Int, doCorrection::Int=1)= rand(GLOBAL_RNG,W,n,doCorrection) | ||
|
|
||
|
|
There was a problem hiding this comment.
These extra lines don't seem necessary
|
|
||
|
|
||
| rand(W::Ginibre)=rand(GLOBAL_RNG, W) | ||
|
|
There was a problem hiding this comment.
These extra lines don't seem necessary
|
If I understand correctly, this fixes #90 ? If so, can we go ahead with the PR? |
4 participants
This PR enables the use of a local random number generator (via the
rngargument) for generating Haar measure matrices, allowing for reproducible results when a specific seed is provided.Additionally, a new test has been added to verify the reproducibility of Haar matrix generation when using local RNG seeds.