Skip to content

spirv-builder: check and clippy shortcuts #505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Firestar99 wants to merge 1 commit into from
+18 −0
Open

spirv-builder: check and clippy shortcuts #505

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions crates/spirv-builder/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -719,6 +719,24 @@ impl SpirvBuilder {
self
}

/// Shortcut for `cargo check`
pub fn check(&mut self) -> Result<CompileResult, SpirvBuilderError> {
self.run_cargo_cmd("check")
}

/// Shortcut for `cargo clippy`
pub fn clippy(&mut self) -> Result<CompileResult, SpirvBuilderError> {
Comment on lines +723 to +728
Copy link
Member Author

@Firestar99 Firestar99 Jan 7, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a huge fan how these are &mut self but build() is only &self. But I also don't want to clone the entire SpirvBuilder just to change that one property, though it probably wouldn't matter performance-wise. Suggestions?

self.run_cargo_cmd("clippy")
}

/// Run the supplied cargo cmd, and ensure to reset the state so [`Self::build`] still works as normal
fn run_cargo_cmd(&mut self, cmd: &str) -> Result<CompileResult, SpirvBuilderError> {
let old = self.cargo_cmd.replace(cmd.into());
let result = self.build();
self.cargo_cmd = old;
result
}

/// Builds the module
pub fn build(&self) -> Result<CompileResult, SpirvBuilderError> {
let metadata_file = invoke_rustc(self)?;
Expand Down
Loading