chore(deps): update bokken image package-ci/ubuntu-22.04 to v4.81.0 (develop) (#3838)

* chore(deps): update bokken image package-ci/ubuntu-22.04 to v4.81.0

* Updates standards and errors

* Updated editors

* Updated CI configuration

* regenerated CI

* typo

* typo

* standards fixes

* added pragma

---------

Co-authored-by: unity-renovate[bot] <120015202+unity-renovate[bot]@users.noreply.github.com>
Co-authored-by: michal-chrobot <michal.chrobot@unity3d.com>

Author: unity-renovate[bot]

.yamato/_run-all.yml

@@ -35,9 +35,7 @@ run_all_package_tests_{{ validation_editors.default }}:
   name: Run All Package Tests [{{ validation_editors.default }} only]
   dependencies:
 {% for platform in test_platforms.desktop -%}
-{% for editor in validation_editors.default -%}
-    - .yamato/package-tests.yml#package_test_-_ngo_{{ editor }}_{{ platform.name }}
-{% endfor -%}
+    - .yamato/package-tests.yml#package_test_-_ngo_{{ validation_editors.default }}_{{ platform.name }}
 {% endfor -%}
 
 # Runs all package tests on minimal supported editor
@@ -71,9 +69,7 @@ run_all_project_tests_{{ validation_editors.default }}:
 {% for project in projects.all -%}
 {% if project.has_tests == "true" -%}
 {% for platform in test_platforms.desktop -%}
-{% for editor in validation_editors.default -%}
-    - .yamato/project-tests.yml#test_{{ project.name }}_{{ platform.name }}_{{ editor }}
-{% endfor -%}
+    - .yamato/project-tests.yml#test_{{ project.name }}_{{ platform.name }}_{{ validation_editors.default }}
 {% endfor -%}
 {% endif -%}
 {% endfor -%}
@@ -97,9 +93,7 @@ run_all_projects_standards:
   dependencies:
 {% for platform in test_platforms.default -%}
 {% for project in projects.all -%}
-{% for editor in validation_editors.default -%}
-    - .yamato/project-standards.yml#standards_{{ platform.name }}_{{ project.name }}_{{ editor }}
-{% endfor -%}
+    - .yamato/project-standards.yml#standards_{{ platform.name }}_{{ project.name }}_{{ validation_editors.default }}
 {% endfor -%}
 {% endfor -%}
 
@@ -123,9 +117,7 @@ run_all_webgl_builds_{{ validation_editors.default }}:
   dependencies:
 {% for project in projects.default -%}
 {% for platform in test_platforms.desktop -%}
-{% for editor in validation_editors.default -%}
-    - .yamato/webgl-build.yml#webgl_build_{{ project.name }}_{{ platform.name }}_{{ editor }}
-{% endfor -%}
+    - .yamato/webgl-build.yml#webgl_build_{{ project.name }}_{{ platform.name }}_{{ validation_editors.default }}
 {% endfor -%}
 {% endfor -%}
 
@@ -161,10 +153,8 @@ run_all_project_tests_desktop_standalone_{{ validation_editors.default }}:
   dependencies:
 {% for project in projects.default -%}
 {% for platform in test_platforms.desktop -%}
-{% for editor in validation_editors.default -%}
 {% for backend in scripting_backends -%}
-    - .yamato/desktop-standalone-tests.yml#desktop_standalone_test_{{ project.name }}_{{ platform.name }}_{{ backend }}_{{ editor }}
-{% endfor -%}
+    - .yamato/desktop-standalone-tests.yml#desktop_standalone_test_{{ project.name }}_{{ platform.name }}_{{ backend }}_{{ validation_editors.default }}
 {% endfor -%}
 {% endfor -%}
 {% endfor -%}
@@ -200,9 +190,7 @@ run_all_project_tests_mobile_standalone_{{ validation_editors.default }}:
   dependencies:
 {% for project in projects.default -%}
 {% for platform in test_platforms.mobile_test -%}
-{% for editor in validation_editors.default -%}
-    - .yamato/mobile-standalone-test.yml#mobile_standalone_test_{{ project.name }}_{{ platform.name }}_{{ editor }}
-{% endfor -%}
+    - .yamato/mobile-standalone-test.yml#mobile_standalone_test_{{ project.name }}_{{ platform.name }}_{{ validation_editors.default }}
 {% endfor -%}
 {% endfor -%}
 
@@ -236,9 +224,7 @@ run_all_project_tests_console_standalone_{{ validation_editors.default }}:
   dependencies:
 {% for project in projects.default -%}
 {% for platform in test_platforms.console_test -%}
-{% for editor in validation_editors.default -%}
-    - .yamato/console-standalone-test.yml#console_standalone_test_{{ project.name }}_{{ platform.name }}_{{ editor }}
-{% endfor -%}
+    - .yamato/console-standalone-test.yml#console_standalone_test_{{ project.name }}_{{ platform.name }}_{{ validation_editors.default }}
 {% endfor -%}
 {% endfor -%}
 

.yamato/_triggers.yml

@@ -109,11 +109,6 @@ pr_code_changes_checks:
     cancel_old_ci: true
 
 
-
-
-
-
-
 # Run all tests on {{ validation_editors.default }} (latest supported editor) on nightly basis.
 # Same subset as pull_request_trigger with addition of mobile/desktop/console tests and webgl builds
 # Those tests are all running on {{ validation_editors.default }} (latest supported editor) since it's daily and running all of them would add a lot of overhead

.yamato/project-standards.yml

@@ -45,9 +45,10 @@ standards_{{ platform.name }}_{{ project.name }}_{{ editor }}:
     - dotnet format --version
 
     - unity-downloader-cli --fast --wait -u {{ editor }} -c editor {% if platform.name == "mac" %} --arch arm64 {% endif %} # For macOS we use ARM64 models. Downloads basic editor
-
     - .Editor/Unity -batchmode -nographics -logFile - -executeMethod Packages.Rider.Editor.RiderScriptEditor.SyncSolution -projectPath {{ project.path }} -quit # This command is used to invoke Unity in a "headless" mode. It's used to sync the project
-    - dotnet run --project=dotnet-tools/netcode.standards -- --project={{ project.path }} --check # Runs standards check
+    - dotnet run --project=dotnet-tools/netcode.standards -- --project={{ project.path }} --fix # Auto-fix formatting issues
+    - git checkout -- {{ project.path }}/Packages/manifest.json {{ project.path }}/Packages/packages-lock.json {{ project.path }}/ProjectSettings/ProjectVersion.txt 2>/dev/null || true # Restore files that Unity may have modified (we only want to check code formatting)
+    - 'git diff --exit-code || (echo "ERROR: Code formatting issues found. Run dotnet run --project=dotnet-tools/netcode.standards -- --project={{ project.path }} --fix locally and commit the changes." && exit 1)' # Fail if formatter made any changes
 {% endfor -%}
 {% endfor -%}
 {% endfor -%}

.yamato/project.metafile

@@ -23,7 +23,7 @@
 small_agent_platform:
     - name: ubuntu
       type: Unity::VM
-      image: package-ci/ubuntu-22.04:v4.77.0
+      image: package-ci/ubuntu-22.04:v4.81.0
       flavor: b1.small
 
 
@@ -38,13 +38,13 @@ test_platforms:
     default:
         - name: ubuntu
           type: Unity::VM
-          image: package-ci/ubuntu-22.04:v4.77.0
+          image: package-ci/ubuntu-22.04:v4.81.0
           flavor: b1.large
           standalone: StandaloneLinux64
     desktop:
         - name: ubuntu
           type: Unity::VM
-          image: package-ci/ubuntu-22.04:v4.77.0
+          image: package-ci/ubuntu-22.04:v4.81.0
           flavor: b1.large
           smaller_flavor: b1.medium
           standalone: StandaloneLinux64

.yamato/wrench/wrench_config.json

@@ -11,7 +11,7 @@
       },
       "InternalOnly": false,
       "NeverPublish": false,
-      "MaxEditorVersion": "6000.2",
+      "MaxEditorVersion": "6000.0",
       "coverageEnabled": false,
       "coverageCommands": [
         "generateAdditionalMetrics;generateHtmlReport;assemblyFilters:ASSEMBLY_NAME;pathReplacePatterns:@*,,**/PackageCache/,;sourcePaths:YAMATO_SOURCE_DIR/Packages;"

Tools/CI/Settings/NGOSettings.cs

@@ -23,7 +23,7 @@ public class NGOSettings : AnnotatedSettingsBase
             new PackageOptions()
             {
                 ReleaseOptions = new ReleaseOptions() { IsReleasing = true },
-                MaximumEditorVersion = "6000.2", // NGOv1.X will be deprecated in 6000.3+ so we won't run tests on higher editor versions
+                MaximumEditorVersion = "6000.0", // NGOv1.X will be deprecated in 6000.3+ so we won't run tests on higher editor versions
                 ValidationOptions = validationOptions
             }
         }

com.unity.netcode.gameobjects/Components/NetworkAnimator.cs

@@ -533,11 +533,8 @@ static AnimationParamEnumWrapper()
         /// </summary>
         private void SpawnCleanup()
         {
-            if (m_NetworkAnimatorStateChangeHandler != null)
-            {
-                m_NetworkAnimatorStateChangeHandler.DeregisterUpdate();
-                m_NetworkAnimatorStateChangeHandler = null;
-            }
+            m_NetworkAnimatorStateChangeHandler?.DeregisterUpdate();
+            m_NetworkAnimatorStateChangeHandler = null;
         }
 
         public override void OnDestroy()

com.unity.netcode.gameobjects/Components/NetworkTransform.cs

@@ -3385,6 +3385,6 @@ private static void DeregisterForTickUpdate(NetworkTransform networkTransform)
 
     internal interface INetworkTransformLogStateEntry
     {
-        void AddLogEntry(NetworkTransform.NetworkTransformState networkTransformState, ulong targetClient, bool preUpdate = false);
+        public void AddLogEntry(NetworkTransform.NetworkTransformState networkTransformState, ulong targetClient, bool preUpdate = false);
     }
 }

com.unity.netcode.gameobjects/Editor/HiddenScriptEditor.cs

@@ -1,5 +1,6 @@
 #pragma warning disable IDE0005
 using Unity.Netcode.Components;
+#pragma warning restore IDE0005
 #if UNITY_UNET_PRESENT
 using Unity.Netcode.Transports.UNET;
 #endif

com.unity.netcode.gameobjects/Runtime/Core/NetworkManager.cs

@@ -608,8 +608,8 @@ internal T Value
         /// </summary>
         internal interface INetworkManagerHelper
         {
-            bool NotifyUserOfNestedNetworkManager(NetworkManager networkManager, bool ignoreNetworkManagerCache = false, bool editorTest = false);
-            void CheckAndNotifyUserNetworkObjectRemoved(NetworkManager networkManager, bool editorTest = false);
+            public bool NotifyUserOfNestedNetworkManager(NetworkManager networkManager, bool ignoreNetworkManagerCache = false, bool editorTest = false);
+            public void CheckAndNotifyUserNetworkObjectRemoved(NetworkManager networkManager, bool editorTest = false);
         }
 
         internal delegate void ResetNetworkManagerDelegate(NetworkManager manager);
@@ -1255,11 +1255,8 @@ internal void ShutdownInternal()
 
             CustomMessagingManager = null;
 
-            if (MessageManager != null)
-            {
-                MessageManager.Dispose();
-                MessageManager = null;
-            }
+            MessageManager?.Dispose();
+            MessageManager = null;
 
             // We need to clean up NetworkObjects before we reset the IsServer
             // and IsClient properties. This provides consistency of these two