test: Adding an equivalent of netcode-qa test in the same way as present in N4E#3376
Closed
michalChrobot wants to merge 1 commit intodevelop-2.0.0from
Closed
test: Adding an equivalent of netcode-qa test in the same way as present in N4E#3376michalChrobot wants to merge 1 commit intodevelop-2.0.0from
michalChrobot wants to merge 1 commit intodevelop-2.0.0from
Conversation
michalChrobot
changed the title
miniwolf
reviewed
Apr 1, 2025
| repo_name = 'com.unity.netcode.gameobjects' | ||
| pr_number = lib.get_env('YAMATO_PR_ID') | ||
|
|
||
| github = lib.GitHubGraphql() |
Collaborator
There was a problem hiding this comment.
You are missing the lib py file.
miniwolf
reviewed
Apr 1, 2025
| """Check PR for having QA assigned.""" | ||
| repo_owner = 'Unity-Technologies' | ||
| repo_name = 'com.unity.netcode.gameobjects' | ||
| pr_number = lib.get_env('YAMATO_PR_ID') |
Collaborator
There was a problem hiding this comment.
Is this environment variable set in yamato?
|
|
Member
Author
|
Outdated PR (I still have this as a task) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a test that checks the following conditions:
In this way we will have the same workflow in both NGO and N4E packages. This will work mostly as additional "reminder" about including tests whenever possible