chore(deps): update bokken image package-ci/ubuntu-22.04 to v4.81.0 (develop-2.0.0)#3839
Conversation
unity-renovate
bot
requested review from
a team,
EmandM and
NoelStephensUnity
as code owners
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
…ttps://github.com/Unity-Technologies/com.unity.netcode.gameobjects into renovate/develop-2.0.0-package-ci-ubuntu-22.04-4.x
|
The new CI image's has stricter dotnet format which is catching pre-existing style issues of:
I'm adding those changes for this PR |
|
6000.4 failures are all expected |
| - dotnet run --project=dotnet-tools/netcode.standards -- --project={{ project.path }} --check # Runs standards check | ||
| - dotnet run --project=dotnet-tools/netcode.standards -- --project={{ project.path }} --fix # Auto-fix formatting issues | ||
| - git checkout -- {{ project.path }}/Packages/manifest.json {{ project.path }}/Packages/packages-lock.json {{ project.path }}/ProjectSettings/ProjectVersion.txt 2>/dev/null || true # Restore files that Unity may have modified (we only want to check code formatting) | ||
| - 'git diff --exit-code || (echo "ERROR: Code formatting issues found. Run dotnet run --project=dotnet-tools/netcode.standards -- --project={{ project.path }} --fix locally and commit the changes." && exit 1)' # Fail if formatter made any changes |
There was a problem hiding this comment.
😻
Love this addition along with the message on how to automatically fix any formatting issues.
(Were the found formatting issues in this PR resolved this way?
There was a problem hiding this comment.
Yup, when standards check job fails it will now print WHY exactly it fails (EXAMPLE) so we know what changes need to be applied
And we can also just run the --fix locally
michalChrobot
deleted the
renovate/develop-2.0.0-package-ci-ubuntu-22.04-4.x
branch
3 participants
This PR contains the following updates:
v4.77.0->v4.81.0Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Unity Renovate Bot.