regression: terrible Mach-O CPU and Memory performance

[VisualEhrmanntraut]

5.3.8953-dev
since last stable, at some point in current (aka 5.3) dev (iirc), Mach-O database performance has been terrible.

databases load very slowly, and higher memory usage (by several GBs in big databases) is observed (Activity Monitor's "Memory" column).

after database load completes, memory usage slightly subsides, but is still higher than before.

[bdash]

Are you talking about performance when working with an existing .bndb, when opening a new binary, or both? Are there specific databases and/or binaries you're seeing it with that you're able to share? You can share them privately via the portal (https://portal.binary.ninja/upload).

[VisualEhrmanntraut]

I'm talking about performance with an existing database, but I have not tried observing if the behaviour occurs when opening a new binary. The issue is not specific to any databases, but the issue becomes prominent on larger ones. Try for example opening a kernelcache from an iOS IPSW, loading the kernel and a lot or all kexts, and observe.

[plafosse]

Could you save that database with Binary Ninja 5.3 and re-open the BNDB to rule out a re-analysis issue?

[VisualEhrmanntraut]

the issue occurs regardless of fresh analysis, reanalysis, or having opened a saved bndb after its (re)analysis.