From c8af699cfb799a76c301c8c8810bfaa579001602 Mon Sep 17 00:00:00 2001 From: niebayes Date: Wed, 28 Jan 2026 07:38:17 +0000 Subject: [PATCH 1/2] update comment --- datafusion/physical-plan/src/filter_pushdown.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/datafusion/physical-plan/src/filter_pushdown.rs b/datafusion/physical-plan/src/filter_pushdown.rs index 37cbd684909ba..90c077fb06494 100644 --- a/datafusion/physical-plan/src/filter_pushdown.rs +++ b/datafusion/physical-plan/src/filter_pushdown.rs @@ -227,7 +227,7 @@ pub struct ChildPushdownResult { /// [`ExecutionPlan::handle_child_pushdown_result`]: crate::ExecutionPlan::handle_child_pushdown_result #[derive(Debug, Clone)] pub struct FilterPushdownPropagation { - /// What filters were pushed into the parent node. + /// Which parent filters were pushed down into this node's children. pub filters: Vec, /// The updated node, if it was updated during pushdown pub updated_node: Option, From 54d1c5cbff0c6ea53da44c5a2a614dc28b697086 Mon Sep 17 00:00:00 2001 From: Adrian Garcia Badaracco <1755071+adriangb@users.noreply.github.com> Date: Fri, 6 Feb 2026 06:24:05 -0600 Subject: [PATCH 2/2] Apply suggestion from @adriangb --- datafusion/physical-plan/src/filter_pushdown.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/datafusion/physical-plan/src/filter_pushdown.rs b/datafusion/physical-plan/src/filter_pushdown.rs index 90c077fb06494..689f629f7bac8 100644 --- a/datafusion/physical-plan/src/filter_pushdown.rs +++ b/datafusion/physical-plan/src/filter_pushdown.rs @@ -221,7 +221,7 @@ pub struct ChildPushdownResult { /// Returned from [`ExecutionPlan::handle_child_pushdown_result`] to communicate /// to the optimizer: /// -/// 1. What to do with any parent filters that were could not be pushed down into the children. +/// 1. What to do with any parent filters that could not be pushed down into the children. /// 2. If the node needs to be replaced in the execution plan with a new node or not. /// /// [`ExecutionPlan::handle_child_pushdown_result`]: crate::ExecutionPlan::handle_child_pushdown_result