Skip to content

Commit 832f83d

Browse files
authored
sync cibuildwheel test env with uv (#2913)
<!-- Thanks for opening a pull request! --> <!-- In the case this PR will resolve an issue, please replace ${GITHUB_ISSUE_ID} below with the actual Github issue id. --> <!-- Closes #${GITHUB_ISSUE_ID} --> # Rationale for this change Follow up to #2912 CI still fails with https://github.com/apache/iceberg-python/actions/runs/21004478697/job/60383069033 ``` Error: cibuildwheel: Command ['C:\\Users\\runneradmin\\AppData\\Local\\Temp\\cibw-run-0tbpuziz\\cp310-win_amd64\\venv-test\\Scripts\\pip.EXE', 'install', 'pytest==7.4.2', 'moto==5.0.1', 'pytest-lazy-fixture==0.6.3', 'sqlalchemy>=2.0.18,<3'] failed with code 1. Error: Process completed with exit code 1. ``` This PR fixes syncs the env with uv so we dont need to explicitly specify the deps here ## Are these changes tested? Yes https://github.com/apache/iceberg-python/actions/runs/21007310527 ## Are there any user-facing changes? <!-- In the case of user-facing changes, please add the changelog label. -->
1 parent 8e4d424 commit 832f83d

File tree

4 files changed

+7
-4
lines changed

4 files changed

+7
-4
lines changed

.github/workflows/pypi-build-artifacts.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -70,8 +70,8 @@ jobs:
7070
# Ignore 32 bit architectures
7171
CIBW_ARCHS: "auto64"
7272
CIBW_PROJECT_REQUIRES_PYTHON: ">=3.10,<3.14"
73-
CIBW_TEST_REQUIRES: "pytest==7.4.2 moto==5.0.1 pytest-lazy-fixture==0.6.3 sqlalchemy>=2.0.18,<3"
74-
CIBW_TEST_COMMAND: "pytest {project}/tests/avro/test_decoder.py"
73+
CIBW_BEFORE_TEST: "uv sync --directory {project} --only-group dev --no-install-project"
74+
CIBW_TEST_COMMAND: "uv run --directory {project} pytest tests/avro/test_decoder.py"
7575
# Ignore tests for pypy since not all dependencies are compiled for it
7676
# and would require a local rust build chain
7777
CIBW_TEST_SKIP: "pp*"

.github/workflows/svn-build-artifacts.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -65,8 +65,8 @@ jobs:
6565
# Ignore 32 bit architectures
6666
CIBW_ARCHS: "auto64"
6767
CIBW_PROJECT_REQUIRES_PYTHON: ">=3.10,<3.14"
68-
CIBW_TEST_REQUIRES: "pytest==7.4.2 moto==5.0.1 pytest-lazy-fixture==0.6.3 sqlalchemy>=2.0.18,<3"
69-
CIBW_TEST_COMMAND: "pytest {project}/tests/avro/test_decoder.py"
68+
CIBW_BEFORE_TEST: "uv sync --directory {project} --only-group dev --no-install-project"
69+
CIBW_TEST_COMMAND: "uv run --directory {project} pytest tests/avro/test_decoder.py"
7070
# Ignore tests for pypy since not all dependencies are compiled for it
7171
# and would require a local rust build chain
7272
CIBW_TEST_SKIP: "pp*"

pyproject.toml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -118,6 +118,7 @@ dev = [
118118
"mypy-boto3-glue>=1.28.18",
119119
"mypy-boto3-dynamodb>=1.28.18",
120120
"pyarrow-stubs>=20.0.0.20251107", # Remove when pyarrow >= 23.0.0 https://github.com/apache/arrow/pull/47609
121+
"sqlalchemy>=2.0.18,<3",
121122
]
122123
# for mkdocs
123124
docs = [

uv.lock

Lines changed: 2 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)