Apple link without cocoapods (#351)

* Add dependencies and xcode helpers

* Add command to patch xcode project

* Copy and sign framework from xcode build phase

* Remove incremental linking

* Use bufferred output when converting plists to xml

* Updated determineFrameworkSlice

* Add changeset

* Cleaning up

* Fix lint issues

* Fixing tests

* Patch all application targets

* Disregard CODE_SIGNING_REQUIRED when deciding to sign

* Re-use existing build phase

* Add check for "macos" when traversing FS for an xcode workspace

* Use NODE_BINARY and read it off the environment

* Use assignment instead of ||= operator now that it's gated by exit_hooks_installed

Author: kraenhansen

.changeset/social-peaches-end.md

@@ -0,0 +1,5 @@
+---
+"react-native-node-api": minor
+---
+
+Modify Xcode project to add a build phase to the main project app to link Node-API frameworks directly

package-lock.json

@@ -35,6 +35,7 @@
     "include",
     "babel-plugin.js",
     "scripts/patch-hermes.rb",
+    "scripts/patch-xcode-project.rb",
     "weak-node-api/**",
     "!weak-node-api/build/",
     "*.js",
@@ -67,7 +68,9 @@
   ],
   "license": "MIT",
   "dependencies": {
+    "@bacons/xcode": "^1.0.0-alpha.29",
     "@expo/plist": "^0.4.7",
+    "@xmldom/xmldom": "^0.8.11",
     "@react-native-node-api/cli-utils": "0.1.4",
     "pkg-dir": "^8.0.0",
     "read-pkg": "^9.0.1",

packages/host/package.json

@@ -3,19 +3,7 @@ require "json"
 package = JSON.parse(File.read(File.join(__dir__, "package.json")))
 
 require_relative "./scripts/patch-hermes"
-
-NODE_PATH ||= `which node`.strip
-CLI_COMMAND ||= "'#{NODE_PATH}' '#{File.join(__dir__, "dist/node/cli/run.js")}'"
-COPY_FRAMEWORKS_COMMAND ||= "#{CLI_COMMAND} link --apple '#{Pod::Config.instance.installation_root}'"
-
-# We need to run this now to ensure the xcframeworks are copied vendored_frameworks are considered
-XCFRAMEWORKS_DIR ||= File.join(__dir__, "xcframeworks")
-unless defined?(@xcframeworks_copied)
-  puts "Executing #{COPY_FRAMEWORKS_COMMAND}"
-  system(COPY_FRAMEWORKS_COMMAND) or raise "Failed to copy xcframeworks"
-  # Setting a flag to avoid running this command on every require
-  @xcframeworks_copied = true
-end
+require_relative "./scripts/patch-xcode-project"
 
 if ENV['RCT_NEW_ARCH_ENABLED'] == '0'
   Pod::UI.warn "React Native Node-API doesn't support the legacy architecture (but RCT_NEW_ARCH_ENABLED == '0')"
@@ -35,16 +23,6 @@ Pod::Spec.new do |s|
 
   s.dependency "weak-node-api"
 
-  s.vendored_frameworks = "auto-linked/apple/*.xcframework"
-  s.script_phase = {
-    :name => 'Copy Node-API xcframeworks',
-    :execution_position => :before_compile,
-    :script => <<-CMD
-      set -e
-      #{COPY_FRAMEWORKS_COMMAND}
-    CMD
-  }
-
   # Use install_modules_dependencies helper to install the dependencies (requires React Native version >=0.71.0).
   # See https://github.com/facebook/react-native/blob/febf6b7f33fdb4904669f99d795eba4c0f95d7bf/scripts/cocoapods/new_architecture.rb#L79.
   if respond_to?(:install_modules_dependencies, true)

packages/host/react-native-node-api.podspec

@@ -0,0 +1,13 @@
+unless defined?(@exit_hooks_installed)
+  # Setting a flag to avoid running this command on every require
+  @exit_hooks_installed = true
+
+  NODE_BINARY = ENV["NODE_BINARY"] || `command -v node`.strip
+  CLI_COMMAND = "'#{NODE_BINARY}' '#{File.join(__dir__, "../dist/node/cli/run.js")}'"
+  PATCH_XCODE_PROJECT_COMMAND = "#{CLI_COMMAND} patch-xcode-project '#{Pod::Config.instance.installation_root}'"
+  
+  # Using an at_exit hook to ensure the command is executed after the pod install is complete
+  at_exit do
+    system(PATCH_XCODE_PROJECT_COMMAND) or raise "Failed to patch the Xcode project"
+  end
+end

packages/host/scripts/patch-xcode-project.rb

@@ -2,7 +2,7 @@ import assert from "node:assert/strict";
 import fs from "node:fs";
 import path from "node:path";
 
-import { getLatestMtime, getLibraryName, MAGIC_FILENAME } from "../path-utils";
+import { getLibraryName, MAGIC_FILENAME } from "../path-utils";
 import {
   getLinkedModuleOutputPath,
   LinkModuleResult,
@@ -17,26 +17,11 @@ const ANDROID_ARCHITECTURES = [
 ] as const;
 
 export async function linkAndroidDir({
-  incremental,
   modulePath,
   naming,
-  platform,
 }: LinkModuleOptions): Promise<LinkModuleResult> {
   const libraryName = getLibraryName(modulePath, naming);
-  const outputPath = getLinkedModuleOutputPath(platform, modulePath, naming);
-
-  if (incremental && fs.existsSync(outputPath)) {
-    const moduleModified = getLatestMtime(modulePath);
-    const outputModified = getLatestMtime(outputPath);
-    if (moduleModified < outputModified) {
-      return {
-        originalPath: modulePath,
-        libraryName,
-        outputPath,
-        skipped: true,
-      };
-    }
-  }
+  const outputPath = getLinkedModuleOutputPath("android", modulePath, naming);
 
   await fs.promises.rm(outputPath, { recursive: true, force: true });
   await fs.promises.cp(modulePath, outputPath, { recursive: true });