Skip to content

Remove compat code from NodeApiHostModuleProvider.mm #29

@kraenhansen

Description

@kraenhansen

Since we'll be depending on an upcoming Hermes version, we need an upcoming React Native version and we can therefore expect more of the APIs available. Specifically, I believe we can rely on the ReactCommon/CxxTurboModuleUtils.h header being available.

https://github.com/callstackincubator/react-native-node-api-modules/blob/4c325deb8e32a438070d93cd59cbde8473083698/packages/react-native-node-api-modules/ios/NodeApiHostModuleProvider.mm#L12

I think we should simplify this file by removing the code related to USE_CXX_TURBO_MODULE_UTILS=0.

Metadata

Metadata

Assignees

Labels

Apple 🍎Anything related to the Apple platform (iOS, macOS, Cocoapods, Xcode, XCFrameworks, etc.)C++

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions