Skip to content

Commit bbd09f6

Browse files
authored
Merge pull request #423 from contentstack/fix/DX-3242
fix: app:create can't choose App Name
2 parents 95ff7cc + 9e5c755 commit bbd09f6

File tree

4 files changed

+36
-36
lines changed

4 files changed

+36
-36
lines changed

README.md

Lines changed: 19 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -16,34 +16,31 @@ $ csdx plugins:install @contentstack/apps-cli
1616
This plugin requires you to be authenticated using [csdx auth:login](https://www.contentstack.com/docs/developers/cli/authenticate-with-the-cli/).
1717

1818
<!-- usage -->
19-
2019
```sh-session
2120
$ npm install -g @contentstack/apps-cli
2221
$ csdx COMMAND
2322
running command...
2423
$ csdx (--version|-v)
25-
@contentstack/apps-cli/1.6.0 darwin-arm64 node-v22.13.1
24+
@contentstack/apps-cli/1.6.1 darwin-arm64 node-v18.20.2
2625
$ csdx --help [COMMAND]
2726
USAGE
2827
$ csdx COMMAND
2928
...
3029
```
31-
3230
<!-- usagestop -->
3331

3432
# Commands
3533

3634
<!-- commands -->
37-
38-
- [`csdx app`](#csdx-app)
39-
- [`csdx app:create`](#csdx-appcreate)
40-
- [`csdx app:delete`](#csdx-appdelete)
41-
- [`csdx app:deploy`](#csdx-appdeploy)
42-
- [`csdx app:get`](#csdx-appget)
43-
- [`csdx app:install`](#csdx-appinstall)
44-
- [`csdx app:reinstall`](#csdx-appreinstall)
45-
- [`csdx app:uninstall`](#csdx-appuninstall)
46-
- [`csdx app:update`](#csdx-appupdate)
35+
* [`csdx app`](#csdx-app)
36+
* [`csdx app:create`](#csdx-appcreate)
37+
* [`csdx app:delete`](#csdx-appdelete)
38+
* [`csdx app:deploy`](#csdx-appdeploy)
39+
* [`csdx app:get`](#csdx-appget)
40+
* [`csdx app:install`](#csdx-appinstall)
41+
* [`csdx app:reinstall`](#csdx-appreinstall)
42+
* [`csdx app:uninstall`](#csdx-appuninstall)
43+
* [`csdx app:update`](#csdx-appupdate)
4744

4845
## `csdx app`
4946

@@ -74,7 +71,7 @@ EXAMPLES
7471
$ csdx app:update
7572
```
7673

77-
_See code: [src/commands/app/index.ts](https://github.com/contentstack/apps-cli/blob/v1.6.0/src/commands/app/index.ts)_
74+
_See code: [src/commands/app/index.ts](https://github.com/contentstack/apps-cli/blob/v1.6.1/src/commands/app/index.ts)_
7875

7976
## `csdx app:create`
8077

@@ -114,7 +111,7 @@ EXAMPLES
114111
$ csdx app:create --name App-4 --app-type organization --org <UID> --boilerplate <Ecommerce App Boilerplate>
115112
```
116113

117-
_See code: [src/commands/app/create.ts](https://github.com/contentstack/apps-cli/blob/v1.6.0/src/commands/app/create.ts)_
114+
_See code: [src/commands/app/create.ts](https://github.com/contentstack/apps-cli/blob/v1.6.1/src/commands/app/create.ts)_
118115

119116
## `csdx app:delete`
120117

@@ -139,7 +136,7 @@ EXAMPLES
139136
$ csdx app:delete --app-uid <value> --org <value> -d ./boilerplate
140137
```
141138

142-
_See code: [src/commands/app/delete.ts](https://github.com/contentstack/apps-cli/blob/v1.6.0/src/commands/app/delete.ts)_
139+
_See code: [src/commands/app/delete.ts](https://github.com/contentstack/apps-cli/blob/v1.6.1/src/commands/app/delete.ts)_
143140

144141
## `csdx app:deploy`
145142

@@ -177,7 +174,7 @@ EXAMPLES
177174
$ csdx app:deploy --org <UID> --app-uid <APP-UID-1> --hosting-type <hosting-with-launch> --launch-project <new> --config <config-path>
178175
```
179176

180-
_See code: [src/commands/app/deploy.ts](https://github.com/contentstack/apps-cli/blob/v1.6.0/src/commands/app/deploy.ts)_
177+
_See code: [src/commands/app/deploy.ts](https://github.com/contentstack/apps-cli/blob/v1.6.1/src/commands/app/deploy.ts)_
181178

182179
## `csdx app:get`
183180

@@ -207,7 +204,7 @@ EXAMPLES
207204
$ csdx app:get --org <value> --app-uid <value> --app-type organization
208205
```
209206

210-
_See code: [src/commands/app/get.ts](https://github.com/contentstack/apps-cli/blob/v1.6.0/src/commands/app/get.ts)_
207+
_See code: [src/commands/app/get.ts](https://github.com/contentstack/apps-cli/blob/v1.6.1/src/commands/app/get.ts)_
211208

212209
## `csdx app:install`
213210

@@ -233,7 +230,7 @@ EXAMPLES
233230
$ csdx app:install --org <UID> --app-uid <APP-UID-1> --stack-api-key <STACK-API-KEY-1>
234231
```
235232

236-
_See code: [src/commands/app/install.ts](https://github.com/contentstack/apps-cli/blob/v1.6.0/src/commands/app/install.ts)_
233+
_See code: [src/commands/app/install.ts](https://github.com/contentstack/apps-cli/blob/v1.6.1/src/commands/app/install.ts)_
237234

238235
## `csdx app:reinstall`
239236

@@ -259,7 +256,7 @@ EXAMPLES
259256
$ csdx app:reinstall --org <UID> --app-uid <APP-UID-1> --stack-api-key <STACK-API-KEY-1>
260257
```
261258

262-
_See code: [src/commands/app/reinstall.ts](https://github.com/contentstack/apps-cli/blob/v1.6.0/src/commands/app/reinstall.ts)_
259+
_See code: [src/commands/app/reinstall.ts](https://github.com/contentstack/apps-cli/blob/v1.6.1/src/commands/app/reinstall.ts)_
263260

264261
## `csdx app:uninstall`
265262

@@ -286,7 +283,7 @@ EXAMPLES
286283
$ csdx app:uninstall --org <UID> --app-uid <APP-UID-1> --installation-uid <INSTALLATION-UID-1>
287284
```
288285

289-
_See code: [src/commands/app/uninstall.ts](https://github.com/contentstack/apps-cli/blob/v1.6.0/src/commands/app/uninstall.ts)_
286+
_See code: [src/commands/app/uninstall.ts](https://github.com/contentstack/apps-cli/blob/v1.6.1/src/commands/app/uninstall.ts)_
290287

291288
## `csdx app:update`
292289

@@ -309,6 +306,5 @@ EXAMPLES
309306
$ csdx app:update --app-manifest ./boilerplate/manifest.json
310307
```
311308

312-
_See code: [src/commands/app/update.ts](https://github.com/contentstack/apps-cli/blob/v1.6.0/src/commands/app/update.ts)_
313-
309+
_See code: [src/commands/app/update.ts](https://github.com/contentstack/apps-cli/blob/v1.6.1/src/commands/app/update.ts)_
314310
<!-- commandsstop -->

package-lock.json

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@contentstack/apps-cli",
3-
"version": "1.6.1",
3+
"version": "1.6.2",
44
"description": "App ClI",
55
"author": "Contentstack CLI",
66
"homepage": "https://github.com/contentstack/contentstack-apps-cli",

src/commands/app/create.ts

Lines changed: 14 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -163,10 +163,6 @@ export default class Create extends BaseCommand<typeof Create> {
163163
* @memberof Create
164164
*/
165165
async flagsPromptQueue() {
166-
if (this.sharedConfig.appName) {
167-
validateAppName(this.sharedConfig.appName);
168-
}
169-
170166
let boilerplate: BoilerplateAppType | null = null;
171167
if (isEmpty(this.sharedConfig.boilerplateName)) {
172168
boilerplate = await selectedBoilerplate();
@@ -177,13 +173,21 @@ export default class Create extends BaseCommand<typeof Create> {
177173
}
178174

179175
if (boilerplate) {
180-
let boilerplateName = this.sharedConfig.appName || boilerplate.name;
181-
if (isEmpty(this.sharedConfig.appName)) {
182-
boilerplateName = boilerplateName
183-
.toLowerCase()
184-
.replace(/ /g, "-")
185-
.substring(0, 20);
176+
let appName: string = this.sharedConfig.appName;
177+
if (!appName) {
178+
appName = await cliux.inquire({
179+
type: "input",
180+
name: "appName",
181+
message: "Enter App Name",
182+
default: boilerplate.name,
183+
});
186184
}
185+
validateAppName(appName);
186+
187+
const boilerplateName = appName
188+
.toLowerCase()
189+
.replace(/ /g, "-")
190+
.substring(0, 20);
187191

188192
this.sharedConfig.boilerplateName = boilerplateName;
189193
this.sharedConfig.appBoilerplateGithubUrl = boilerplate.link;

0 commit comments

Comments
 (0)