Skip to content

Commit 67606e6

Browse files
authored
small cleanup of disabled Clang compiler warnings (danmar#8166)
1 parent 6cf6b21 commit 67606e6

File tree

3 files changed

+4
-2
lines changed

3 files changed

+4
-2
lines changed

cmake/compileroptions.cmake

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -132,8 +132,6 @@ elseif(CMAKE_CXX_COMPILER_ID MATCHES "Clang")
132132
endif()
133133

134134
# TODO: fix and enable these warnings - or move to suppression list below
135-
add_compile_options_safe(-Wno-documentation-unknown-command) # TODO: Clang currently does not support all commands
136-
add_compile_options_safe(-Wno-unused-exception-parameter)
137135
add_compile_options_safe(-Wno-sign-conversion)
138136
add_compile_options_safe(-Wno-shadow-field-in-constructor)
139137
add_compile_options_safe(-Wno-shorten-64-to-32)

externals/tinyxml2/CMakeLists.txt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,8 @@ if (CMAKE_CXX_COMPILER_ID MATCHES "Clang")
1515
target_compile_options_safe(tinyxml2 -Wno-zero-as-null-pointer-constant)
1616
target_compile_options_safe(tinyxml2 -Wno-format-nonliteral)
1717
target_compile_options_safe(tinyxml2 -Wno-inconsistent-missing-destructor-override)
18+
target_compile_options_safe(tinyxml2 -Wno-sign-conversion)
19+
target_compile_options_safe(tinyxml2 -Wno-double-promotion)
1820
endif()
1921
if(CYGWIN)
2022
target_compile_definitions(-D_LARGEFILE_SOURCE) # required for fseeko() and ftello()

lib/json.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ SUPPRESS_WARNING_CLANG_PUSH("-Wextra-semi-stmt")
2828
SUPPRESS_WARNING_CLANG_PUSH("-Wzero-as-null-pointer-constant")
2929
SUPPRESS_WARNING_CLANG_PUSH("-Wformat")
3030
SUPPRESS_WARNING_CLANG_PUSH("-Wfloat-conversion")
31+
SUPPRESS_WARNING_CLANG_PUSH("-Wimplicit-float-conversion")
3132

3233
#define PICOJSON_USE_INT64
3334
#include <picojson.h> // IWYU pragma: export
@@ -37,6 +38,7 @@ SUPPRESS_WARNING_CLANG_POP
3738
SUPPRESS_WARNING_CLANG_POP
3839
SUPPRESS_WARNING_CLANG_POP
3940
SUPPRESS_WARNING_CLANG_POP
41+
SUPPRESS_WARNING_CLANG_POP
4042
SUPPRESS_WARNING_GCC_POP
4143
SUPPRESS_WARNING_POP
4244

0 commit comments

Comments
 (0)