Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
22.21.1
24.13.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Check if `@types/node` and workflows have been updated to Node 24

echo "=== `@types/node` versions in package.json files ==="
fd -t f '^package\.json$' --exec jq -r '.file = input_filename | {file, types_node: (.devDependencies."@types/node" // .dependencies."@types/node")}' {} \;

echo -e "\n=== GitHub Actions node-version references ==="
fd -t f -e yml -e yaml .github/workflows/ --exec rg 'node-version' {} -A 1 \; 2>/dev/null || echo "Checking for workflows..."
fd -t f -e yml -e yaml .github/ -exec cat {} \; 2>/dev/null | rg -C 2 'node-version' || echo "No node-version found in workflows"

echo -e "\n=== All .nvmrc files ==="
fd -t f '\.nvmrc$' --exec sh -c 'echo "File: {}"; cat {}' \;

Repository: deepnote/vscode-deepnote

Length of output: 530


Update @types/node to Node 24 major version.

Root package.json has @types/node: ^22.15.1, but .nvmrc specifies Node 24.13.0. Update to ^24.x. Also update test environment at src/test/vscode-notebook-perf/package.json from ^18.15.0.

🤖 Prompt for AI Agents
In @.nvmrc at line 1, Update TypeScript Node type definitions to match the Node
version in .nvmrc: bump the root package.json dependency "@types/node" from
^22.15.1 to a ^24.x range, and also update the test environment dependency in
src/test/vscode-notebook-perf/package.json from ^18.15.0 to a compatible ^24.x
version; run npm/yarn install and adjust any type-specific code or tsconfig
settings if type errors appear after upgrading.

2 changes: 1 addition & 1 deletion src/test/vscode-notebook-perf/.nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
22.21.1
24.13.0
Loading