Fix codecov upload condition in CI workflow (#361)

* Fix codecov upload condition in CI workflow

The upload condition used 'discard' which never matches any matrix
value, preventing coverage data from being uploaded. Changed to 'ubuntu'
to match the actual os-type matrix value.

* Replace deprecated Codecov bash uploader with official GitHub Action

The bash uploader now requires a token and is deprecated.
Using codecov/codecov-action@v5 which handles authentication
automatically for public repos via GitHub OIDC.

* Add gcovr step to generate coverage report before Codecov upload

The codecov-action@v5 does not auto-process gcov data like the old bash
uploader did. This adds a step to run gcovr to convert .gcda/.gcno files
to Cobertura XML format, which codecov can parse.

* Add CODECOV_TOKEN for protected branch uploads

Codecov requires authentication token for uploading coverage reports
to protected branches.

* Trigger CI to test Codecov upload with token

* Add --root option to gcovr for correct source path mapping

The coverage report was unusable because gcovr generated paths relative
to the build directory (e.g., ../src/webserver.cpp). Adding --root ..
ensures paths are relative to the repository root, allowing Codecov to
correctly match source files.

* Exclude test directory from coverage reports

* Ignore tests

Author: etr

.github/workflows/verify-build.yml

@@ -665,8 +665,16 @@ jobs:
          sleep 5 && ab -n 1000000 -c 100 127.0.0.1:8080/plaintext
       if: ${{ matrix.build-type == 'threads' }}
 
-    - name: Push code coverage data
+    - name: Generate coverage report
       run: |
-        cd build ;
-        bash <(curl -s https://codecov.io/bash) ;
-      if: ${{ matrix.os-type == 'discard' && matrix.c-compiler == 'gcc' && matrix.debug == 'debug' && matrix.coverage == 'coverage' && success() }}
+        cd build
+        gcovr --root .. --exclude test/ --xml coverage.xml --xml-pretty
+      if: ${{ matrix.os-type == 'ubuntu' && matrix.c-compiler == 'gcc' && matrix.debug == 'debug' && matrix.coverage == 'coverage' && success() }}
+
+    - name: Upload coverage to Codecov
+      uses: codecov/codecov-action@v5
+      with:
+        token: ${{ secrets.CODECOV_TOKEN }}
+        files: build/coverage.xml
+        fail_ci_if_error: false
+      if: ${{ matrix.os-type == 'ubuntu' && matrix.c-compiler == 'gcc' && matrix.debug == 'debug' && matrix.coverage == 'coverage' && success() }}

codecov.yml

@@ -18,3 +18,6 @@ comment:
   layout: "reach,diff,flags,files,footer"
   behavior: default
   require_changes: no
+
+ignore:
+  - "test"