Fix POST args with empty values not being parsed (issue #268) (#351)

* Fix POST args with empty values not being parsed (issue #268)

Destroy post processor before invoking the callback to ensure pending
POST body keys with empty values are properly finalized. Without this,
POST data like "arg1=val1&arg2=" would fail to include arg2.

The fix moves MHD_destroy_post_processor call to finalize_answer()
before the resource callback is invoked, rather than waiting for
the modded_request destructor.

Added test cases verifying:
- arg1=val1&arg2= correctly parses both args
- arg1= correctly parses as empty string
- arg1=&arg2= correctly parses both as empty strings

This supersedes PR #269 with the requested code style changes.

* Fix Windows build: replace rand_r with portable rand()

rand_r is POSIX-specific and not available on Windows. Since this is
just a stress test where thread-safe randomness isn't critical, use
the portable rand() function instead.

Author: etr

src/webserver.cpp

@@ -738,6 +738,10 @@ MHD_Result webserver::finalize_answer(MHD_Connection* connection, struct details
 
     if (found) {
         try {
+            if (mr->pp != nullptr) {
+                MHD_destroy_post_processor(mr->pp);
+                mr->pp = nullptr;
+            }
             if (hrm->is_allowed(method)) {
                 mr->dhrs = ((hrm)->*(mr->callback))(*mr->dhr);  // copy in memory (move in case)
                 if (mr->dhrs.get() == nullptr || mr->dhrs->get_response_code() == -1) {

test/integ/basic.cpp

@@ -993,6 +993,62 @@ LT_BEGIN_AUTO_TEST(basic_suite, empty_arg)
     curl_easy_cleanup(curl);
 LT_END_AUTO_TEST(empty_arg)
 
+LT_BEGIN_AUTO_TEST(basic_suite, empty_arg_value_at_end)
+    // Test for issue #268: POST body keys without values at the end
+    // are not processed when using application/x-www-form-urlencoded
+    simple_resource resource;
+    LT_ASSERT_EQ(true, ws->register_resource("base", &resource));
+    curl_global_init(CURL_GLOBAL_ALL);
+
+    // Test case 1: arg2 has empty value at end (the bug case)
+    {
+    string s;
+    CURL *curl = curl_easy_init();
+    CURLcode res;
+    curl_easy_setopt(curl, CURLOPT_URL, "localhost:" PORT_STRING "/base");
+    curl_easy_setopt(curl, CURLOPT_POSTFIELDS, "arg1=val1&arg2=");
+    curl_easy_setopt(curl, CURLOPT_WRITEFUNCTION, writefunc);
+    curl_easy_setopt(curl, CURLOPT_WRITEDATA, &s);
+    res = curl_easy_perform(curl);
+    LT_ASSERT_EQ(res, 0);
+    // arg1="val1", arg2="" -> response should be "val1"
+    LT_CHECK_EQ(s, "val1");
+    curl_easy_cleanup(curl);
+    }
+
+    // Test case 2: only arg1 with empty value
+    {
+    string s;
+    CURL *curl = curl_easy_init();
+    CURLcode res;
+    curl_easy_setopt(curl, CURLOPT_URL, "localhost:" PORT_STRING "/base");
+    curl_easy_setopt(curl, CURLOPT_POSTFIELDS, "arg1=");
+    curl_easy_setopt(curl, CURLOPT_WRITEFUNCTION, writefunc);
+    curl_easy_setopt(curl, CURLOPT_WRITEDATA, &s);
+    res = curl_easy_perform(curl);
+    LT_ASSERT_EQ(res, 0);
+    // arg1="" -> response should be ""
+    LT_CHECK_EQ(s, "");
+    curl_easy_cleanup(curl);
+    }
+
+    // Test case 3: both args with empty values
+    {
+    string s;
+    CURL *curl = curl_easy_init();
+    CURLcode res;
+    curl_easy_setopt(curl, CURLOPT_URL, "localhost:" PORT_STRING "/base");
+    curl_easy_setopt(curl, CURLOPT_POSTFIELDS, "arg1=&arg2=");
+    curl_easy_setopt(curl, CURLOPT_WRITEFUNCTION, writefunc);
+    curl_easy_setopt(curl, CURLOPT_WRITEDATA, &s);
+    res = curl_easy_perform(curl);
+    LT_ASSERT_EQ(res, 0);
+    // arg1="", arg2="" -> response should be ""
+    LT_CHECK_EQ(s, "");
+    curl_easy_cleanup(curl);
+    }
+LT_END_AUTO_TEST(empty_arg_value_at_end)
+
 LT_BEGIN_AUTO_TEST(basic_suite, no_response)
     no_response_resource resource;
     LT_ASSERT_EQ(true, ws->register_resource("base", &resource));
@@ -1588,12 +1644,10 @@ LT_BEGIN_AUTO_TEST(basic_suite, thread_safety)
     });
 
     auto get_thread = std::thread([&](){
-        unsigned int seed = 42;
         while (!done) {
             CURL *curl = curl_easy_init();
             std::string s;
-            std::string url = "localhost:" PORT_STRING "/route" + std::to_string(
-                                            static_cast<int>((rand_r(&seed) * 10000000.0) / RAND_MAX));
+            std::string url = "localhost:" PORT_STRING "/route" + std::to_string(rand() % 10000000);  // NOLINT(runtime/threadsafe_fn)
             curl_easy_setopt(curl, CURLOPT_URL, url.c_str());
             curl_easy_setopt(curl, CURLOPT_HTTPGET, 1L);
             curl_easy_setopt(curl, CURLOPT_WRITEFUNCTION, writefunc);