Skip to content

feat(span-streaming): Add more span properties #5421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sentrivana merged 6 commits into from
Feb 4, 2026
Merged

feat(span-streaming): Add more span properties #5421

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
dd89e68
feat(span-streaming): Add more span properties
sentrivana Feb 4, 2026
014e2cc
use attrs directly in batcher
sentrivana Feb 4, 2026
ba0478e
fix span_id
sentrivana Feb 4, 2026
4768e99
add span_Id to batcher
sentrivana Feb 4, 2026
bae1f67
compat
sentrivana Feb 4, 2026
4de063c
Merge branch 'master' into ivana/span-first/span-op-and-friends
sentrivana Feb 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion sentry_sdk/_span_batcher.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,9 @@ def add(self, span: "StreamedSpan") -> None:
def _to_transport_format(item: "StreamedSpan") -> "Any":
# TODO[span-first]
res: "dict[str, Any]" = {
"name": item.name,
"span_id": item.span_id,
"name": item._name,
"status": item._status,
}

if item._attributes:
Expand Down
112 changes: 108 additions & 4 deletions sentry_sdk/traces.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,15 +6,61 @@
"""

import uuid
from enum import Enum
from typing import TYPE_CHECKING

from sentry_sdk.consts import SPANDATA
from sentry_sdk.utils import format_attribute

if TYPE_CHECKING:
from typing import Optional
from typing import Optional, Union
from sentry_sdk._types import Attributes, AttributeValue


FLAGS_CAPACITY = 10


class SpanStatus(str, Enum):
OK = "ok"
ERROR = "error"

def __str__(self) -> str:
return self.value


# Segment source, see
Copy link
Contributor Author

@sentrivana sentrivana Feb 4, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This source related stuff is all just copied from the old TransactionSource and will be used by integrations and DSC later.

# https://getsentry.github.io/sentry-conventions/generated/attributes/sentry.html#sentryspansource
class SegmentSource(str, Enum):
COMPONENT = "component"
CUSTOM = "custom"
ROUTE = "route"
TASK = "task"
URL = "url"
VIEW = "view"

def __str__(self) -> str:
return self.value


# These are typically high cardinality and the server hates them
LOW_QUALITY_SEGMENT_SOURCES = [
SegmentSource.URL,
]
Copy link

@cursor cursor bot Feb 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused constant LOW_QUALITY_SEGMENT_SOURCES is dead code

Low Severity

LOW_QUALITY_SEGMENT_SOURCES is defined but never used anywhere in the codebase. A similar constant LOW_QUALITY_TRANSACTION_SOURCES exists in tracing.py and is actively used. This appears to be scaffolding code that isn't yet integrated.

Fix in Cursor Fix in Web

Copy link
Contributor Author

@sentrivana sentrivana Feb 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coming soon (tm)



SOURCE_FOR_STYLE = {
"endpoint": SegmentSource.COMPONENT,
"function_name": SegmentSource.COMPONENT,
"handler_name": SegmentSource.COMPONENT,
"method_and_path_pattern": SegmentSource.ROUTE,
"path": SegmentSource.URL,
"route_name": SegmentSource.COMPONENT,
"route_pattern": SegmentSource.ROUTE,
"uri_template": SegmentSource.ROUTE,
"url": SegmentSource.ROUTE,
}


class StreamedSpan:
"""
A span holds timing information of a block of code.
Expand All @@ -26,9 +72,12 @@ class StreamedSpan:
"""

__slots__ = (
"name",
"_name",
"_attributes",
"_span_id",
"_trace_id",
"_status",
"_flags",
)

def __init__(
Expand All @@ -38,13 +87,19 @@ def __init__(
attributes: "Optional[Attributes]" = None,
trace_id: "Optional[str]" = None,
):
self.name: str = name
self._name: str = name
self._attributes: "Attributes" = {}
if attributes:
for attribute, value in attributes.items():
self.set_attribute(attribute, value)

self._trace_id = trace_id
self._span_id: "Optional[str]" = None
self._trace_id: "Optional[str]" = trace_id

self.set_status(SpanStatus.OK)
self.set_source(SegmentSource.CUSTOM)

self._flags: dict[str, bool] = {}

def get_attributes(self) -> "Attributes":
return self._attributes
Expand All @@ -62,6 +117,55 @@ def remove_attribute(self, key: str) -> None:
except KeyError:
pass

def get_status(self) -> "Union[SpanStatus, str]":
if self._status in {s.value for s in SpanStatus}:
return SpanStatus(self._status)

return self._status

def set_status(self, status: "Union[SpanStatus, str]") -> None:
if isinstance(status, Enum):
status = status.value

self._status = status

def set_http_status(self, http_status: int) -> None:
self.set_attribute(SPANDATA.HTTP_STATUS_CODE, http_status)

if http_status >= 400:
self.set_status(SpanStatus.ERROR)
else:
self.set_status(SpanStatus.OK)

def get_name(self) -> str:
return self._name

def set_name(self, name: str) -> None:
self._name = name

def set_flag(self, flag: str, result: bool) -> None:
if len(self._flags) < FLAGS_CAPACITY:
self._flags[flag] = result

def set_op(self, op: str) -> None:
self.set_attribute("sentry.op", op)

def set_origin(self, origin: str) -> None:
self.set_attribute("sentry.origin", origin)

def set_source(self, source: "Union[str, SegmentSource]") -> None:
if isinstance(source, Enum):
source = source.value

self.set_attribute("sentry.span.source", source)

@property
def span_id(self) -> str:
if not self._span_id:
self._span_id = uuid.uuid4().hex[16:]

return self._span_id

@property
def trace_id(self) -> str:
if not self._trace_id:
Expand Down
Loading