Address review comments

henrymercer · henrymercer · commit 281b26524519 · 2026-03-04T12:16:54.000+01:00
diff --git a/lib/init-action-post.js b/lib/init-action-post.js
diff --git a/src/init-action-post-helper.test.ts b/src/init-action-post-helper.test.ts
@@ -374,6 +374,7 @@ test("saves overlay status when overlay-base analysis did not complete successfu
         attemptedToBuildOverlayBaseDatabase: true,
         builtOverlayBaseDatabase: false,
         job: {
+          checkRunId: undefined,
           workflowRunId: 12345,
           workflowRunAttempt: 1,
           name: "analyze",
diff --git a/src/init-action-post-helper.ts b/src/init-action-post-helper.ts
@@ -283,7 +283,7 @@ async function recordOverlayStatus(
       attemptedToBuildOverlayBaseDatabase: true,
       builtOverlayBaseDatabase: false,
     },
-    Number.isNaN(checkRunId) ? undefined : checkRunId,
+    checkRunId !== undefined && checkRunId >= 0 ? checkRunId : undefined,
   );
 
   const diskUsage = await checkDiskUsage(logger);
diff --git a/src/overlay/status.ts b/src/overlay/status.ts
@@ -74,7 +74,7 @@ export function createOverlayStatus(
     workflowRunId: getWorkflowRunID(),
     workflowRunAttempt: getWorkflowRunAttempt(),
     name: getRequiredEnvParam("GITHUB_JOB"),
-    ...(checkRunId !== undefined && { checkRunId }),
+    checkRunId,
   };
   return {
     ...attributes,
