Copilot feedback

MichaelRFairhurst · MichaelRFairhurst · commit 5c6355632854 · 2026-03-02T12:22:50.000-08:00
diff --git a/cpp/misra/src/rules/RULE-4-1-2/ImplicitDeclarationOfCopyConstructor.ql b/cpp/misra/src/rules/RULE-4-1-2/ImplicitDeclarationOfCopyConstructor.ql
@@ -3,7 +3,7 @@
  * @name RULE-4-1-2: Implicit declaration of copy constructors is a deprecated language feature should not be used
  * @description Deprecated language features such as implicit declarations of copy constructors are
  *              only supported for backwards compatibility; these are considered bad practice, or
- *              have been superceded by better alternatives.
+ *              have been superseded by better alternatives.
  * @kind problem
  * @precision very-high
  * @problem.severity warning
@@ -14,8 +14,6 @@
  *       external/misra/obligation/advisory
  */
 
-import cpp
-import codingstandards.cpp.misra
 import cpp
 import codingstandards.cpp.misra
 import codingstandards.cpp.types.ImplicitSpecialMemberFunctions
diff --git a/cpp/misra/src/rules/RULE-4-1-2/ImplicitDeclarationOfCopyConstructorAudit.ql b/cpp/misra/src/rules/RULE-4-1-2/ImplicitDeclarationOfCopyConstructorAudit.ql
@@ -3,7 +3,7 @@
  * @name RULE-4-1-2: Implicit declaration of copy constructors is a deprecated language feature should not be used
  * @description Deprecated language features such as implicit declarations of copy constructors are
  *              only supported for backwards compatibility; these are considered bad practice, or
- *              have been superceded by better alternatives.
+ *              have been superseded by better alternatives.
  * @kind problem
  * @precision low
  * @problem.severity warning
diff --git a/cpp/misra/src/rules/RULE-4-1-2/NoexceptSpecifierThrow.ql b/cpp/misra/src/rules/RULE-4-1-2/NoexceptSpecifierThrow.ql
@@ -3,7 +3,7 @@
  * @name RULE-4-1-2: The noexcept specifier throw() is a deprecated language feature should not be used
  * @description Deprecated language features such as the noexcept specifier throw() are only
  *              supported for backwards compatibility; these are considered bad practice, or have
- *              been superceded by better alternatives.
+ *              been superseded by better alternatives.
  * @kind problem
  * @precision high
  * @problem.severity warning
diff --git a/cpp/misra/src/rules/RULE-4-1-2/RedeclarationOfStaticConstexprDataMember.ql b/cpp/misra/src/rules/RULE-4-1-2/RedeclarationOfStaticConstexprDataMember.ql
@@ -3,7 +3,7 @@
  * @name RULE-4-1-2: Redeclaration of static constexpr data members is a deprecated language feature should not be used
  * @description Deprecated language features such as redeclaration of static constexpr data members
  *              are only supported for backwards compatibility; these are considered bad practice,
- *              or have been superceded by better alternatives.
+ *              or have been superseded by better alternatives.
  * @kind problem
  * @precision high
  * @problem.severity warning
diff --git a/cpp/misra/src/rules/RULE-4-1-2/UseOfDeprecatedAllocatorVoid.ql b/cpp/misra/src/rules/RULE-4-1-2/UseOfDeprecatedAllocatorVoid.ql
@@ -2,7 +2,7 @@
  * @id cpp/misra/use-of-deprecated-allocator-void
  * @name RULE-4-1-2: Specialization allocator<void> is a deprecated language feature and should not be used
  * @description Deprecated language features such as allocator<void> are only supported for
- *              backwards compatibility; these are considered bad practice, or have been superceded
+ *              backwards compatibility; these are considered bad practice, or have been superseded
  *              by better alternatives.
  * @kind problem
  * @precision very-high
diff --git a/cpp/misra/src/rules/RULE-4-1-2/UseOfDeprecatedCHeaders.ql b/cpp/misra/src/rules/RULE-4-1-2/UseOfDeprecatedCHeaders.ql
@@ -2,7 +2,7 @@
  * @id cpp/misra/use-of-deprecated-c-headers
  * @name RULE-4-1-2: Use of <ccomplex>, <cstdalign>, and <cstdbool>, or <ctgmath> is deprecated and therefore these headers should not be used
  * @description These C standard library headers are only supported for backwards compatibility;
- *              these are considered bad practice, or have been superceded by better alternatives.
+ *              these are considered bad practice, or have been superseded by better alternatives.
  * @kind problem
  * @precision very-high
  * @problem.severity warning
diff --git a/cpp/misra/src/rules/RULE-4-1-2/UseOfDeprecatedFunctionBinderTypedefMember.ql b/cpp/misra/src/rules/RULE-4-1-2/UseOfDeprecatedFunctionBinderTypedefMember.ql
@@ -3,7 +3,7 @@
  * @name RULE-4-1-2: Certain members of function binder typedefs are deprecated language features and should not be used
  * @description Deprecated language features such as certain function binder typedef members are
  *              only supported for backwards compatibility; these are considered bad practice, or
- *              have been superceded by better alternatives.
+ *              have been superseded by better alternatives.
  * @kind problem
  * @precision high
  * @problem.severity warning
diff --git a/cpp/misra/src/rules/RULE-4-1-2/UseOfDeprecatedIsLiteralTypeTraits.ql b/cpp/misra/src/rules/RULE-4-1-2/UseOfDeprecatedIsLiteralTypeTraits.ql
@@ -2,7 +2,7 @@
  * @id cpp/misra/use-of-deprecated-is-literal-type-traits
  * @name RULE-4-1-2: The is-literal type traits are deprecated language features and should not be used
  * @description Deprecated language features such as is-literal type traits are only supported for
- *              backwards compatibility; these are considered bad practice, or have been superceded
+ *              backwards compatibility; these are considered bad practice, or have been superseded
  *              by better alternatives.
  * @kind problem
  * @precision very-high
diff --git a/cpp/misra/src/rules/RULE-4-1-2/UseOfDeprecatedRawStorageIterator.ql b/cpp/misra/src/rules/RULE-4-1-2/UseOfDeprecatedRawStorageIterator.ql
@@ -2,7 +2,7 @@
  * @id cpp/misra/use-of-deprecated-raw-storage-iterator
  * @name RULE-4-1-2: Class raw_storage_iterator is a deprecated language feature and should not be used
  * @description Deprecated language features such as raw_storage_iterator are only supported for
- *              backwards compatibility; these are considered bad practice, or have been superceded
+ *              backwards compatibility; these are considered bad practice, or have been superseded
  *              by better alternatives.
  * @kind problem
  * @precision high
diff --git a/cpp/misra/src/rules/RULE-4-1-2/UseOfDeprecatedSharedPtrUnique.ql b/cpp/misra/src/rules/RULE-4-1-2/UseOfDeprecatedSharedPtrUnique.ql
@@ -2,7 +2,7 @@
  * @id cpp/misra/use-of-deprecated-shared-ptr-unique
  * @name RULE-4-1-2: Observer member shared_ptr::unique is a deprecated language feature and should not be used
  * @description Deprecated language features such as shared_ptr::unique are only supported for
- *              backwards compatibility; these are considered bad practice, or have been superceded
+ *              backwards compatibility; these are considered bad practice, or have been superseded
  *              by better alternatives.
  * @kind problem
  * @precision very-high
diff --git a/cpp/misra/src/rules/RULE-4-1-2/UseOfDeprecatedStdAllocatorMember.ql b/cpp/misra/src/rules/RULE-4-1-2/UseOfDeprecatedStdAllocatorMember.ql
@@ -3,7 +3,7 @@
  * @name RULE-4-1-2: Certain members of std::allocator are deprecated language features and should not be used
  * @description Deprecated language features such as certain members of std::allocator are only
  *              supported for backwards compatibility; these are considered bad practice, or have
- *              been superceded by better alternatives.
+ *              been superseded by better alternatives.
  * @kind problem
  * @precision very-high
  * @problem.severity warning
@@ -39,7 +39,7 @@ class DeprecatedAllocatorUsingMember extends UsingAliasTypedefType, DeprecatedUs
   override Locatable getAUseLocation() { result.(TypeMention).getMentionedType() = this }
 
   override string getAUseDescription() {
-    result = "Use of deprecated allocator member 'std::allocator<void>::pointer'."
+    result = "Use of deprecated allocator member 'std::allocator::" + this.getName() + "'."
   }
 }
 
@@ -59,7 +59,7 @@ class DeprecatedAllocatorMemberFunction extends MemberFunction, DeprecatedUse {
   override Locatable getAUseLocation() { result.(FunctionCall).getTarget() = this }
 
   override string getAUseDescription() {
-    result = "Use of deprecated allocator member 'std::allocator<void>::" + this.getName() + "'."
+    result = "Use of deprecated allocator member 'std::allocator::" + this.getName() + "'."
   }
 }
 
diff --git a/cpp/misra/src/rules/RULE-4-1-2/UseOfDeprecatedStdIteratorBaseClass.ql b/cpp/misra/src/rules/RULE-4-1-2/UseOfDeprecatedStdIteratorBaseClass.ql
@@ -2,7 +2,7 @@
  * @id cpp/misra/use-of-deprecated-std-iterator-base-class
  * @name RULE-4-1-2: Base class std::iterator is a deprecated language feature and should not be used
  * @description Deprecated language features such as extending std::iterator are only supported for
- *              backwards compatibility; these are considered bad practice, or have been superceded
+ *              backwards compatibility; these are considered bad practice, or have been superseded
  *              by better alternatives.
  * @kind problem
  * @precision very-high
diff --git a/cpp/misra/src/rules/RULE-4-1-2/UseOfDeprecatedStrStreamClass.ql b/cpp/misra/src/rules/RULE-4-1-2/UseOfDeprecatedStrStreamClass.ql
@@ -1,8 +1,8 @@
 /**
  * @id cpp/misra/use-of-deprecated-str-stream-class
- * @name RULE-4-1-2: The char* stream classes strstreambuf, istreamstr, ostramstr, and strstream are deprecated and should not be used
+ * @name RULE-4-1-2: The char* stream classes strstreambuf, istrstream, ostrstream, and strstream are deprecated and should not be used
  * @description Deprecated language features such as the char* stream classes are only supported for
- *              backwards compatibility; these are considered bad practice, or have been superceded
+ *              backwards compatibility; these are considered bad practice, or have been superseded
  *              by better alternatives.
  * @kind problem
  * @precision very-high
diff --git a/cpp/misra/src/rules/RULE-4-1-2/UseOfDeprecatedTemporaryBuffers.ql b/cpp/misra/src/rules/RULE-4-1-2/UseOfDeprecatedTemporaryBuffers.ql
@@ -2,7 +2,7 @@
  * @id cpp/misra/use-of-deprecated-temporary-buffers
  * @name RULE-4-1-2: Temporary buffers are deprecated language features and should not be used
  * @description Deprecated language features such as temporary buffers are only supported for
- *              backwards compatibility; these are considered bad practice, or have been superceded
+ *              backwards compatibility; these are considered bad practice, or have been superseded
  *              by better alternatives.
  * @kind problem
  * @precision very-high
diff --git a/cpp/misra/src/rules/RULE-4-1-2/UseOfDeprecatedUnaryOrBinaryNegate.ql b/cpp/misra/src/rules/RULE-4-1-2/UseOfDeprecatedUnaryOrBinaryNegate.ql
@@ -3,7 +3,7 @@
  * @name RULE-4-1-2: Typedefs unary_negate and binary_negate are deprecated language features and should not be used
  * @description Deprecated language features such as unary_negate and binary_negate are only
  *              supported for backwards compatibility; these are considered bad practice, or have
- *              been superceded by better alternatives.
+ *              been superseded by better alternatives.
  * @kind problem
  * @precision very-high
  * @problem.severity warning
diff --git a/cpp/misra/src/rules/RULE-4-1-2/UseOfUncaughtException.ql b/cpp/misra/src/rules/RULE-4-1-2/UseOfUncaughtException.ql
@@ -2,7 +2,7 @@
  * @id cpp/misra/use-of-uncaught-exception
  * @name RULE-4-1-2: Function uncaught_exception is a deprecated language feature should not be used
  * @description Deprecated language features such as uncaught_exception are only supported for
- *              backwards compatibility; these are considered bad practice, or have been superceded
+ *              backwards compatibility; these are considered bad practice, or have been superseded
  *              by better alternatives.
  * @kind problem
  * @precision very-high
diff --git a/cpp/misra/test/rules/RULE-4-1-2/UseOfDeprecatedStdAllocatorMember.expected b/cpp/misra/test/rules/RULE-4-1-2/UseOfDeprecatedStdAllocatorMember.expected
@@ -1,7 +1,7 @@
-| test.cpp:86:24:86:30 | type mention | Use of deprecated allocator member 'std::allocator<void>::pointer'. |
-| test.cpp:88:9:88:16 | call to allocate | Use of deprecated allocator member 'std::allocator<void>::allocate'. |
-| test.cpp:89:5:89:11 | call to address | Use of deprecated allocator member 'std::allocator<void>::address'. |
-| test.cpp:90:5:90:13 | call to construct | Use of deprecated allocator member 'std::allocator<void>::construct'. |
-| test.cpp:91:5:91:11 | call to destroy | Use of deprecated allocator member 'std::allocator<void>::destroy'. |
-| test.cpp:93:5:93:12 | call to max_size | Use of deprecated allocator member 'std::allocator<void>::max_size'. |
+| test.cpp:86:24:86:30 | type mention | Use of deprecated allocator member 'std::allocator::pointer'. |
+| test.cpp:88:9:88:16 | call to allocate | Use of deprecated allocator member 'std::allocator::allocate'. |
+| test.cpp:89:5:89:11 | call to address | Use of deprecated allocator member 'std::allocator::address'. |
+| test.cpp:90:5:90:13 | call to construct | Use of deprecated allocator member 'std::allocator::construct'. |
+| test.cpp:91:5:91:11 | call to destroy | Use of deprecated allocator member 'std::allocator::destroy'. |
+| test.cpp:93:5:93:12 | call to max_size | Use of deprecated allocator member 'std::allocator::max_size'. |
 | test.cpp:96:30:96:35 | type mention | Use of deprecated allocator member class 'std::allocator::rebind'. |
diff --git a/rule_packages/cpp/Toolchain3.json b/rule_packages/cpp/Toolchain3.json
