Fix Bugs caught by @mbaluda

Author: MichaelRFairhurst

cpp/misra/src/rules/RULE-0-2-1/UnusedLimitedVisibilityVariable.ql

@@ -33,7 +33,7 @@ class UnusedVariable extends Variable {
       description = "Variable '" + this.getName() + "' is unused."
       or
       this instanceof FullyUnusedMemberVariable and
-      description = "Member variable '" + this.getQualifiedName() + "' is unused."
+      description = "Member variable '" + this.getName() + "' is unused."
     ) and
     not (isConstant(this) and this.getFile() instanceof HeaderFile and hasNamespaceScope(this))
   }

cpp/misra/test/rules/RULE-0-2-1/UnusedLimitedVisibilityVariable.expected

@@ -10,6 +10,9 @@
 | test_global_or_namespace.cpp:29:4:29:4 | a | Variable '(unnamed namespace)::a' is unused. |
 | test_global_or_namespace.cpp:37:5:37:6 | x3 | Variable '(unnamed namespace)::N1::x3' is unused. |
 | test_global_or_namespace.cpp:47:5:47:5 | a | Variable '(unnamed namespace)::N1::a' is unused. |
-| test_header.hpp:22:13:22:14 | m1 | Member variable 'HeaderClass::m1' is unused. |
-| test_member.cpp:4:7:4:8 | m1 | Member variable 'test::A::m1' is unused. |
-| test_member.cpp:31:7:31:8 | m1 | Member variable 'test::C::m1' is unused. |
+| test_header.hpp:22:13:22:14 | m1 | Member variable 'm1' is unused. |
+| test_header.hpp:28:20:28:21 | m1 | Member variable 'm1' is unused. |
+| test_member.cpp:4:7:4:8 | m1 | Member variable 'm1' is unused. |
+| test_member.cpp:17:9:17:11 | pad | Member variable 'pad' is unused. |
+| test_member.cpp:19:9:19:11 | sm2 | Member variable 'sm2' is unused. |
+| test_member.cpp:31:7:31:8 | m1 | Member variable 'm1' is unused. |

cpp/misra/test/rules/RULE-0-2-1/test_header.hpp

@@ -19,6 +19,13 @@ const int cg8 = 8; // COMPLIANT - unused constant variable defined in header
 }
 
 class HeaderClass {
-  const int m1 = 9;            // NON_COMPLIANT -- not namespace scope
-  static const int m2 = 30234; // NON_COMPLIANT -- not namespace scope
-};
+  const int m1 = 9;            // NON_COMPLIANT -- no linkage
+  static const int m2 = 30234; // COMPLIANT -- external linkage
+};
+
+namespace {
+class HeaderClass2 {
+  static const int m1 =
+      9; // NON_COMPLIANT -- internal linkage, not namespace scope
+};
+} // namespace