Fix: remove xmlCtxtUseOptions from XXE model (not an XML content sink)

Co-authored-by: geoffw0 <40627776+geoffw0@users.noreply.github.com>

Author: Copilot

rust/ql/lib/codeql/rust/security/XxeExtensions.qll

@@ -58,8 +58,6 @@ module Xxe {
  */
 private predicate libxml2ParseCall(Call call, int xmlArg, int optionsArg) {
   exists(string fname | call.getStaticTarget().getName().getText() = fname |
-    fname = "xmlCtxtUseOptions" and xmlArg = 0 and optionsArg = 1
-    or
     fname = "xmlReadFile" and xmlArg = 0 and optionsArg = 2
     or
     fname = ["xmlReadDoc", "xmlReadFd"] and xmlArg = 0 and optionsArg = 3

rust/ql/test/query-tests/security/CWE-611/Xxe.expected

@@ -23,14 +23,14 @@ edges
 | main.rs:132:9:132:16 | user_xml | main.rs:140:33:140:40 | user_xml | provenance |  |
 | main.rs:132:9:132:16 | user_xml | main.rs:141:36:141:43 | user_xml | provenance |  |
 | main.rs:132:9:132:16 | user_xml | main.rs:142:31:142:38 | user_xml | provenance |  |
-| main.rs:132:20:132:33 | ...::args | main.rs:132:20:132:35 | ...::args(...) [element] | provenance | Src:MaD:488  |
-| main.rs:132:20:132:35 | ...::args(...) [element] | main.rs:132:20:132:42 | ... .nth(...) [Some] | provenance | MaD:440 |
-| main.rs:132:20:132:42 | ... .nth(...) [Some] | main.rs:132:20:132:62 | ... .unwrap_or_default() | provenance | MaD:9229 |
+| main.rs:132:20:132:33 | ...::args | main.rs:132:20:132:35 | ...::args(...) [element] | provenance | Src:MaD:1  |
+| main.rs:132:20:132:35 | ...::args(...) [element] | main.rs:132:20:132:42 | ... .nth(...) [Some] | provenance | MaD:2 |
+| main.rs:132:20:132:42 | ... .nth(...) [Some] | main.rs:132:20:132:62 | ... .unwrap_or_default() | provenance | MaD:3 |
 | main.rs:132:20:132:62 | ... .unwrap_or_default() | main.rs:132:9:132:16 | user_xml | provenance |  |
 | main.rs:133:9:133:21 | user_filename | main.rs:138:29:138:41 | user_filename | provenance |  |
-| main.rs:133:25:133:38 | ...::args | main.rs:133:25:133:40 | ...::args(...) [element] | provenance | Src:MaD:488  |
-| main.rs:133:25:133:40 | ...::args(...) [element] | main.rs:133:25:133:47 | ... .nth(...) [Some] | provenance | MaD:440 |
-| main.rs:133:25:133:47 | ... .nth(...) [Some] | main.rs:133:25:133:67 | ... .unwrap_or_default() | provenance | MaD:9229 |
+| main.rs:133:25:133:38 | ...::args | main.rs:133:25:133:40 | ...::args(...) [element] | provenance | Src:MaD:1  |
+| main.rs:133:25:133:40 | ...::args(...) [element] | main.rs:133:25:133:47 | ... .nth(...) [Some] | provenance | MaD:2 |
+| main.rs:133:25:133:47 | ... .nth(...) [Some] | main.rs:133:25:133:67 | ... .unwrap_or_default() | provenance | MaD:3 |
 | main.rs:133:25:133:67 | ... .unwrap_or_default() | main.rs:133:9:133:21 | user_filename | provenance |  |
 | main.rs:135:26:135:34 | &user_xml [&ref] | main.rs:66:25:66:38 | ...: ... [&ref] | provenance |  |
 | main.rs:135:27:135:34 | user_xml | main.rs:135:26:135:34 | &user_xml [&ref] | provenance |  |
@@ -48,6 +48,10 @@ edges
 | main.rs:141:36:141:43 | user_xml | main.rs:141:35:141:43 | &user_xml [&ref] | provenance |  |
 | main.rs:142:30:142:38 | &user_xml [&ref] | main.rs:108:29:108:42 | ...: ... [&ref] | provenance |  |
 | main.rs:142:31:142:38 | user_xml | main.rs:142:30:142:38 | &user_xml [&ref] | provenance |  |
+models
+| 1 | Source: std::env::args; ReturnValue.Element; commandargs |
+| 2 | Summary: <_ as core::iter::traits::iterator::Iterator>::nth; Argument[self].Reference.Element; ReturnValue.Field[core::option::Option::Some(0)]; value |
+| 3 | Summary: <core::option::Option>::unwrap_or_default; Argument[self].Field[core::option::Option::Some(0)]; ReturnValue; value |
 nodes
 | main.rs:66:25:66:38 | ...: ... [&ref] | semmle.label | ...: ... [&ref] |
 | main.rs:68:19:68:26 | user_xml | semmle.label | user_xml |

rust/ql/test/query-tests/security/CWE-611/Xxe.qlref

@@ -1,3 +1,4 @@
 query: queries/security/CWE-611/Xxe.ql
 postprocess:
+ - utils/test/PrettyPrintModels.ql
  - utils/test/InlineExpectationsTestQuery.ql