clean up and fix tests

Author: kerobbi

pkg/github/dependencies.go

@@ -229,7 +229,6 @@ func NewRequestDeps(
 	lockdownMode bool,
 	repoAccessOpts []lockdown.RepoAccessOption,
 	t translations.TranslationHelperFunc,
-	flags FeatureFlags,
 	contentWindowSize int,
 ) *RequestDeps {
 	return &RequestDeps{
@@ -238,7 +237,6 @@ func NewRequestDeps(
 		lockdownMode:      lockdownMode,
 		RepoAccessOpts:    repoAccessOpts,
 		T:                 t,
-		Flags:             flags,
 		ContentWindowSize: contentWindowSize,
 	}
 }

pkg/github/server_test.go

@@ -55,9 +55,9 @@ func (s stubDeps) GetRawClient(ctx context.Context) (*raw.Client, error) {
 func (s stubDeps) GetRepoAccessCache(ctx context.Context) (*lockdown.RepoAccessCache, error) {
 	return s.repoAccessCache, nil
 }
-func (s stubDeps) GetT() translations.TranslationHelperFunc { return s.t }
-func (s stubDeps) GetFlags() FeatureFlags                   { return s.flags }
-func (s stubDeps) GetContentWindowSize() int                { return s.contentWindowSize }
+func (s stubDeps) GetT() translations.TranslationHelperFunc  { return s.t }
+func (s stubDeps) GetFlags(ctx context.Context) FeatureFlags { return s.flags }
+func (s stubDeps) GetContentWindowSize() int                 { return s.contentWindowSize }
 
 // Helper functions to create stub client functions for error testing
 func stubClientFnFromHTTP(httpClient *http.Client) func(context.Context) (*github.Client, error) {

pkg/http/server.go

@@ -89,9 +89,6 @@ func RunHTTPServer(cfg HTTPServerConfig) error {
 		cfg.LockdownMode,
 		repoAccessOpts,
 		t,
-		github.FeatureFlags{
-			LockdownMode: cfg.LockdownMode,
-		},
 		cfg.ContentWindowSize,
 	)