introduce constants for client names and remove wrong ide name for mcp apps support

Author: mattdholloway

pkg/github/helper_test.go

@@ -291,10 +291,16 @@ func createMCPRequest(args any) mcp.CallToolRequest {
 	}
 }
 
+// Well-known MCP client names used in tests.
+const (
+	ClientNameVSCodeInsiders = "Visual Studio Code - Insiders"
+	ClientNameVSCode         = "Visual Studio Code"
+)
+
 // createMCPRequestWithSession creates a CallToolRequest with a ServerSession
-// that has the given client name in its InitializeParams. This is used to test
-// UI capability detection based on ClientInfo.Name.
-func createMCPRequestWithSession(t *testing.T, clientName string, args any) mcp.CallToolRequest {
+// that has the given client name in its InitializeParams. When withUI is true
+// the session advertises MCP Apps UI support via the capability extension.
+func createMCPRequestWithSession(t *testing.T, clientName string, withUI bool, args any) mcp.CallToolRequest {
 	t.Helper()
 
 	argsMap, ok := args.(map[string]any)
@@ -307,8 +313,7 @@ func createMCPRequestWithSession(t *testing.T, clientName string, args any) mcp.
 	srv := mcp.NewServer(&mcp.Implementation{Name: "test"}, nil)
 
 	caps := &mcp.ClientCapabilities{}
-	// If the client is a known UI-supporting client, add the UI extension
-	if clientName == "Visual Studio Code - Insiders" || clientName == "Visual Studio Code" {
+	if withUI {
 		caps.AddExtension("io.modelcontextprotocol/ui", map[string]any{
 			"mimeTypes": []string{"text/html;profile=mcp-app"},
 		})

pkg/github/issues_test.go

@@ -957,7 +957,7 @@ func Test_IssueWrite_InsidersMode_UIGate(t *testing.T) {
 	handler := serverTool.Handler(deps)
 
 	t.Run("UI client without _ui_submitted returns form message", func(t *testing.T) {
-		request := createMCPRequestWithSession(t, "Visual Studio Code - Insiders", map[string]any{
+		request := createMCPRequestWithSession(t, ClientNameVSCodeInsiders, true, map[string]any{
 			"method": "create",
 			"owner":  "owner",
 			"repo":   "repo",
@@ -971,7 +971,7 @@ func Test_IssueWrite_InsidersMode_UIGate(t *testing.T) {
 	})
 
 	t.Run("UI client with _ui_submitted executes directly", func(t *testing.T) {
-		request := createMCPRequestWithSession(t, "Visual Studio Code - Insiders", map[string]any{
+		request := createMCPRequestWithSession(t, ClientNameVSCodeInsiders, true, map[string]any{
 			"method":        "create",
 			"owner":         "owner",
 			"repo":          "repo",

pkg/github/pullrequests_test.go

@@ -2185,7 +2185,7 @@ func Test_CreatePullRequest_InsidersMode_UIGate(t *testing.T) {
 	handler := serverTool.Handler(deps)
 
 	t.Run("UI client without _ui_submitted returns form message", func(t *testing.T) {
-		request := createMCPRequestWithSession(t, "Visual Studio Code", map[string]any{
+		request := createMCPRequestWithSession(t, ClientNameVSCodeInsiders, true, map[string]any{
 			"owner": "owner",
 			"repo":  "repo",
 			"title": "Test PR",
@@ -2200,7 +2200,7 @@ func Test_CreatePullRequest_InsidersMode_UIGate(t *testing.T) {
 	})
 
 	t.Run("UI client with _ui_submitted executes directly", func(t *testing.T) {
-		request := createMCPRequestWithSession(t, "Visual Studio Code", map[string]any{
+		request := createMCPRequestWithSession(t, ClientNameVSCodeInsiders, true, map[string]any{
 			"owner":         "owner",
 			"repo":          "repo",
 			"title":         "Test PR",