Linter fixes and ctx no longer needed

Author: omgitsads

pkg/http/oauth/oauth.go

@@ -3,7 +3,6 @@
 package oauth
 
 import (
-	"context"
 	"fmt"
 	"net/http"
 	"strings"
@@ -59,7 +58,7 @@ type AuthHandler struct {
 }
 
 // NewAuthHandler creates a new OAuth auth handler.
-func NewAuthHandler(ctx context.Context, cfg *Config, apiHost utils.APIHostResolver) (*AuthHandler, error) {
+func NewAuthHandler(cfg *Config, apiHost utils.APIHostResolver) (*AuthHandler, error) {
 	if cfg == nil {
 		cfg = &Config{}
 	}

pkg/http/oauth/oauth_test.go

@@ -53,7 +53,7 @@ func TestNewAuthHandler(t *testing.T) {
 		t.Run(tc.name, func(t *testing.T) {
 			t.Parallel()
 
-			handler, err := NewAuthHandler(t.Context(), tc.cfg, dotcomHost)
+			handler, err := NewAuthHandler(tc.cfg, dotcomHost)
 			require.NoError(t, err)
 			require.NotNil(t, handler)
 
@@ -451,7 +451,7 @@ func TestHandleProtectedResource(t *testing.T) {
 			dotcomHost, err := utils.NewAPIHost("https://api.github.com")
 			require.NoError(t, err)
 
-			handler, err := NewAuthHandler(t.Context(), tc.cfg, dotcomHost)
+			handler, err := NewAuthHandler(tc.cfg, dotcomHost)
 			require.NoError(t, err)
 
 			router := chi.NewRouter()
@@ -496,7 +496,7 @@ func TestRegisterRoutes(t *testing.T) {
 	dotcomHost, err := utils.NewAPIHost("https://api.github.com")
 	require.NoError(t, err)
 
-	handler, err := NewAuthHandler(t.Context(), &Config{
+	handler, err := NewAuthHandler(&Config{
 		BaseURL: "https://api.example.com",
 	}, dotcomHost)
 	require.NoError(t, err)
@@ -565,7 +565,7 @@ func TestProtectedResourceResponseFormat(t *testing.T) {
 	dotcomHost, err := utils.NewAPIHost("https://api.github.com")
 	require.NoError(t, err)
 
-	handler, err := NewAuthHandler(t.Context(), &Config{
+	handler, err := NewAuthHandler(&Config{
 		BaseURL: "https://api.example.com",
 	}, dotcomHost)
 	require.NoError(t, err)
@@ -676,11 +676,10 @@ func TestAPIHostResolver_AuthorizationServerURL(t *testing.T) {
 					assert.Contains(t, err.Error(), tc.errorContains)
 				}
 				return
-			} else {
-				require.NoError(t, err)
 			}
+			require.NoError(t, err)
 
-			handler, err := NewAuthHandler(t.Context(), &Config{
+			handler, err := NewAuthHandler(&Config{
 				BaseURL: "https://api.example.com",
 			}, apiHost)
 			require.NoError(t, err)
@@ -708,7 +707,6 @@ func TestAPIHostResolver_AuthorizationServerURL(t *testing.T) {
 				}
 				return
 			}
-			require.NoError(t, err)
 
 			responseAuthServers, ok := response["authorization_servers"].([]any)
 			require.True(t, ok)

pkg/http/server.go

@@ -136,7 +136,7 @@ func RunHTTPServer(cfg ServerConfig) error {
 
 	r := chi.NewRouter()
 	handler := NewHTTPMcpHandler(ctx, &cfg, deps, t, logger, apiHost, append(serverOptions, WithFeatureChecker(featureChecker), WithOAuthConfig(oauthCfg))...)
-	oauthHandler, err := oauth.NewAuthHandler(ctx, oauthCfg, apiHost)
+	oauthHandler, err := oauth.NewAuthHandler(oauthCfg, apiHost)
 	if err != nil {
 		return fmt.Errorf("failed to create OAuth handler: %w", err)
 	}