Skip to content

Add kid to JsonWebKey definition#569

Closed
funkybob wants to merge 2 commits intomicrosoft:masterfrom
funkybob:feature/funkybob/add-jwk-kid
Closed

Add kid to JsonWebKey definition#569
funkybob wants to merge 2 commits intomicrosoft:masterfrom
funkybob:feature/funkybob/add-jwk-kid

Conversation

@funkybob
Copy link

@funkybob funkybob commented Sep 3, 2018

This is to address microsoft/TypeScript#26854

@sandersn
Copy link
Member

@funkybob you need to commit the generated code in addition to the widl change.

@HolgerJeromin
Copy link
Contributor

Thanks for jumping in.
This is not in the widl from upstream.
So the correct place would be the addTypes.json

@funkybob
Copy link
Author

@sandersn I honestly don't know how to make the "generated code"... I ran into this problem when trying to migrate a project to TypeScript, figured I'd trying to solve it, and got this far before I ran out of time to contribute, and worked around it locally.

@sandersn
Copy link
Member

It's npm run build and then you diff baseline and generated. If it looks right, then you run npm run baseline-accept.

@funkybob funkybob force-pushed the feature/funkybob/add-jwk-kid branch from 0792aa4 to 4ddb2c0 Compare October 29, 2018 20:33
@msftclas
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

❌ funkybob sign now
You have signed the CLA already but the status is still pending? Let us recheck it.

@saschanaz
Copy link
Collaborator

Looks like this is not in the WebCrypto spec. Filing an issue there may help. (Reposting from microsoft/TypeScript#26854 (comment))

@sandersn
Copy link
Member

Sounds like we should close this here then.

@pranjaldaffodil
Copy link

Can't believe nobody bothered to report this to W3C in 8 years! I have opened w3c/webcrypto#427 now

@pranjaldaffodil
Copy link

@sandersn what's the process once WebCrypto updates it on their side?

@saschanaz
Copy link
Collaborator

It will be automatically updated as the crawled spec data is served by @webref/idl

@pranjaldaffodil
Copy link

It will be automatically updated as the crawled spec data is served by @webref/idl

What about adding an interface for JWK Set? It should be relatively simple to create, but will that also require changes in WebCrypto spec?

I noticed that not just kid but there were even more missing parameters/attributes and have added them to the above mentioned issue.

@saschanaz
Copy link
Collaborator

Not being in the spec implies not being in browser implementations, so yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants