Skip to content

Commit 4fcf2c3

Browse files
committed
test case fixes
1 parent eab2820 commit 4fcf2c3

File tree

3 files changed

+11
-10
lines changed

3 files changed

+11
-10
lines changed

tests/issues/test_141_resource_templates.py

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -40,11 +40,12 @@ def get_user_profile_mismatch(different_param: str) -> str: # pragma: no cover
4040
return f"Profile for user {different_param}"
4141

4242
# Test case 4: Template with extra function parameters
43-
with pytest.raises(ValueError, match="Mismatch between URI parameters"):
44-
45-
@mcp.resource("resource://users/{user_id}/profile")
46-
def get_user_profile_extra(user_id: str, extra_param: str) -> str: # pragma: no cover
47-
return f"Profile for user {user_id}"
43+
# when no default value given it becomes a required
44+
# query parameter when default value is given its a
45+
# optional query parameter
46+
@mcp.resource("resource://users_extra/{user_id}/profile")
47+
def get_user_profile_extra(user_id: str, extra_param: str = "") -> str: # pragma: no cover
48+
return f"Profile for user {user_id}"
4849

4950
# Test case 5: Template with missing function parameters
5051
with pytest.raises(

tests/server/fastmcp/test_func_metadata.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1300,6 +1300,8 @@ async def test_async_required_param_missing(
13001300
):
13011301
with pytest.raises(ValidationError):
13021302
await decorated_async_func(opt_int=100)
1303+
1304+
13031305
def test_disallowed_type_qualifier():
13041306
from mcp.server.fastmcp.exceptions import InvalidSignature
13051307

tests/server/fastmcp/test_server.py

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -860,11 +860,9 @@ async def test_resource_with_params(self):
860860
parameters don't match"""
861861
mcp = FastMCP()
862862

863-
with pytest.raises(ValueError, match="Mismatch between URI parameters"):
864-
865-
@mcp.resource("resource://data")
866-
def get_data_fn(param: str) -> str: # pragma: no cover
867-
return f"Data: {param}"
863+
@mcp.resource("resource://data")
864+
def get_data_fn(param: str) -> str: # pragma: no cover
865+
return f"Data: {param}"
868866

869867
@pytest.mark.anyio
870868
async def test_resource_with_uri_params(self):

0 commit comments

Comments
 (0)