From 10167d343b2b48e5e8b58cfc042fe0dfd47d34dd Mon Sep 17 00:00:00 2001 From: Ross Lawley Date: Mon, 2 Feb 2026 16:14:56 +0000 Subject: [PATCH] Revert NettyByteBuf.asReadOnly change (#1871) Originally introduced in 057649fd This change had the unintended side effect of leaking netty ByteBufs when logging. JAVA-5982 --- .../com/mongodb/internal/connection/netty/NettyByteBuf.java | 2 +- .../internal/connection/CommandHelperSpecification.groovy | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/driver-core/src/main/com/mongodb/internal/connection/netty/NettyByteBuf.java b/driver-core/src/main/com/mongodb/internal/connection/netty/NettyByteBuf.java index 72235b4676..48bd0eb77d 100644 --- a/driver-core/src/main/com/mongodb/internal/connection/netty/NettyByteBuf.java +++ b/driver-core/src/main/com/mongodb/internal/connection/netty/NettyByteBuf.java @@ -251,7 +251,7 @@ public ByteBuf limit(final int newLimit) { @Override public ByteBuf asReadOnly() { - return new NettyByteBuf(proxied.asReadOnly().retain(), false); + return this; } @Override diff --git a/driver-core/src/test/functional/com/mongodb/internal/connection/CommandHelperSpecification.groovy b/driver-core/src/test/functional/com/mongodb/internal/connection/CommandHelperSpecification.groovy index c0535166b0..0d3d836a2a 100644 --- a/driver-core/src/test/functional/com/mongodb/internal/connection/CommandHelperSpecification.groovy +++ b/driver-core/src/test/functional/com/mongodb/internal/connection/CommandHelperSpecification.groovy @@ -25,6 +25,7 @@ import com.mongodb.connection.SocketSettings import com.mongodb.internal.connection.netty.NettyStreamFactory import org.bson.BsonDocument import org.bson.BsonInt32 +import spock.lang.Ignore import spock.lang.Specification import java.util.concurrent.CountDownLatch @@ -52,9 +53,11 @@ class CommandHelperSpecification extends Specification { } def cleanup() { + InternalStreamConnection.setRecordEverything(false) connection?.close() } + @Ignore("JAVA-5982") def 'should execute command asynchronously'() { when: BsonDocument receivedDocument = null