Skip to content

Commit 9cc7cee

Browse files
deps: update ada to 3.4.3
PR-URL: #62049 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
1 parent 6291ea7 commit 9cc7cee

File tree

2 files changed

+22
-9
lines changed

2 files changed

+22
-9
lines changed

deps/ada/ada.cpp

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
/* auto-generated on 2026-01-30 13:29:04 -0500. Do not edit! */
1+
/* auto-generated on 2026-02-23 21:29:24 -0500. Do not edit! */
22
/* begin file src/ada.cpp */
33
#include "ada.h"
44
/* begin file src/checkers.cpp */
@@ -14495,6 +14495,12 @@ bool url_aggregator::set_pathname(const std::string_view input) {
1449514495
if (get_pathname().starts_with("//") && !has_authority() && !has_dash_dot()) {
1449614496
buffer.insert(components.pathname_start, "/.");
1449714497
components.pathname_start += 2;
14498+
if (components.search_start != url_components::omitted) {
14499+
components.search_start += 2;
14500+
}
14501+
if (components.hash_start != url_components::omitted) {
14502+
components.hash_start += 2;
14503+
}
1449814504
}
1449914505
ADA_ASSERT_TRUE(validate());
1450014506
return true;

deps/ada/ada.h

Lines changed: 15 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
/* auto-generated on 2026-01-30 13:29:04 -0500. Do not edit! */
1+
/* auto-generated on 2026-02-23 21:29:24 -0500. Do not edit! */
22
/* begin file include/ada.h */
33
/**
44
* @file ada.h
@@ -8091,6 +8091,12 @@ inline void url_aggregator::update_base_pathname(const std::string_view input) {
80918091
// output.
80928092
buffer.insert(components.pathname_start, "/.");
80938093
components.pathname_start += 2;
8094+
if (components.search_start != url_components::omitted) {
8095+
components.search_start += 2;
8096+
}
8097+
if (components.hash_start != url_components::omitted) {
8098+
components.hash_start += 2;
8099+
}
80948100
}
80958101

80968102
uint32_t difference = replace_and_resize(
@@ -9530,13 +9536,14 @@ url_pattern_component<regex_provider>::create_component_match_result(
95309536
auto result =
95319537
url_pattern_component_result{.input = std::move(input), .groups = {}};
95329538

9533-
// Optimization: Let's reserve the size.
9534-
result.groups.reserve(exec_result.size());
9535-
95369539
// We explicitly start iterating from 0 even though the spec
95379540
// says we should start from 1. This case is handled by the
9538-
// std_regex_provider.
9539-
for (size_t index = 0; index < exec_result.size(); index++) {
9541+
// std_regex_provider which removes the full match from index 0.
9542+
// Use min() to guard against potential mismatches between
9543+
// exec_result size and group_name_list size.
9544+
const size_t size = std::min(exec_result.size(), group_name_list.size());
9545+
result.groups.reserve(size);
9546+
for (size_t index = 0; index < size; index++) {
95409547
result.groups.emplace(group_name_list[index],
95419548
std::move(exec_result[index]));
95429549
}
@@ -11221,14 +11228,14 @@ constructor_string_parser<regex_provider>::parse(std::string_view input) {
1122111228
#ifndef ADA_ADA_VERSION_H
1122211229
#define ADA_ADA_VERSION_H
1122311230

11224-
#define ADA_VERSION "3.4.2"
11231+
#define ADA_VERSION "3.4.3"
1122511232

1122611233
namespace ada {
1122711234

1122811235
enum {
1122911236
ADA_VERSION_MAJOR = 3,
1123011237
ADA_VERSION_MINOR = 4,
11231-
ADA_VERSION_REVISION = 2,
11238+
ADA_VERSION_REVISION = 3,
1123211239
};
1123311240

1123411241
} // namespace ada

0 commit comments

Comments
 (0)