test: remove unnecessary process.exit calls from test files

PR-URL: #62020
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

Author: aduh95

benchmark/buffers/buffer-transcode.js

@@ -8,7 +8,7 @@ const encodings = ['latin1', 'ascii', 'ucs2', 'utf8'];
 
 if (!hasIntl) {
   console.log('Skipping: `transcode` is only available on platforms that support i18n`');
-  process.exit(0);
+  return;
 }
 
 const bench = common.createBenchmark(main, {

test/parallel/test-child-process-fork-advanced-header-serialization.js

@@ -13,11 +13,9 @@ if (process.argv[2] === 'child-buffer') {
     v & 0xFF,
   ]);
   const fd = process.channel?.fd;
-  if (fd === undefined) {
-    // skip test
-    process.exit(0);
+  if (fd !== undefined) {
+    fs.writeSync(fd, payload);
   }
-  fs.writeSync(fd, payload);
   return;
 }
 

test/parallel/test-child-process-internal.js

@@ -34,9 +34,6 @@ if (process.argv[2] === 'child') {
 
   // Send internal message
   process.send(internal);
-
-  process.exit(0);
-
 } else {
 
   const fork = require('child_process').fork;

test/parallel/test-child-process-silent.js

@@ -20,7 +20,7 @@
 // USE OR OTHER DEALINGS IN THE SOFTWARE.
 
 'use strict';
-require('../common');
+const common = require('../common');
 const assert = require('assert');
 const childProcess = require('child_process');
 
@@ -44,9 +44,7 @@ if (process.argv[2] === 'pipe') {
   // Allow child process to self terminate
   child.disconnect();
 
-  child.on('exit', function() {
-    process.exit(0);
-  });
+  child.on('exit', common.mustCall());
 
 } else {
   // Testcase | start primary && child IPC test

test/parallel/test-child-process-spawnsync-input.js

@@ -65,7 +65,6 @@ if (process.argv.includes('spawnchild')) {
       checkSpawnSyncRet(ret);
       break;
   }
-  process.exit(0);
   return;
 }
 

test/parallel/test-child-process-stdout-flush-exit.js

@@ -36,7 +36,6 @@ if (process.argv[2] === 'child') {
     console.log('filler');
   }
   console.log('goodbye');
-  process.exit(0);
 } else {
   // parent process
   const spawn = require('child_process').spawn;

test/parallel/test-cli-eval.js

@@ -35,7 +35,7 @@ const fixtures = require('../common/fixtures');
 
 if (process.argv.length > 2) {
   console.log(process.argv.slice(2).join(' '));
-  process.exit(0);
+  return;
 }
 
 // Assert that nothing is written to stdout.

test/parallel/test-inspector-port-zero-cluster.js

@@ -35,7 +35,7 @@ function serialFork() {
 
 if (cluster.isPrimary) {
   Promise.all([serialFork(), serialFork(), serialFork()])
-    .then(common.mustCall((ports) => {
+    .then((ports) => {
       ports.splice(0, 0, process.debugPort);
       // 4 = [primary, worker1, worker2, worker3].length()
       assert.strictEqual(ports.length, 4);
@@ -44,12 +44,8 @@ if (cluster.isPrimary) {
       assert.strictEqual(ports[0] === 65535 ? 1024 : ports[0] + 1, ports[1]);
       assert.strictEqual(ports[1] === 65535 ? 1024 : ports[1] + 1, ports[2]);
       assert.strictEqual(ports[2] === 65535 ? 1024 : ports[2] + 1, ports[3]);
-    }))
-    .catch(
-      (err) => {
-        console.error(err);
-        process.exit(1);
-      });
+    })
+    .then(common.mustCall());
 } else {
-  process.exit(0);
+  process.disconnect();
 }

test/parallel/test-net-listen-twice.js

@@ -19,7 +19,7 @@ if (cluster.isPrimary) {
     server.listen();
   } catch (e) {
     console.error(e);
-    process.exit(0);
+    return;
   }
   let i = 0;
   process.on('internalMessage', (msg) => {

test/parallel/test-permission-allow-child-process-cli.js

@@ -24,7 +24,7 @@ if (process.argv[2] === 'child') {
     code: 'ERR_ACCESS_DENIED',
     permission: 'FileSystemWrite',
   }));
-  process.exit(0);
+  return;
 }
 
 // Guarantee the initial state