Skip to content

Commit dc04ab6

Browse files
committed
test: skip test-url on --without-intl and --shared-ada builds
1 parent 2ae6d8f commit dc04ab6

File tree

2 files changed

+10
-6
lines changed

2 files changed

+10
-6
lines changed

shell.nix

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -107,12 +107,7 @@ pkgs.mkShell {
107107
BUILD_WITH = if (ninja != null) then "ninja" else "make";
108108
NINJA = pkgs.lib.optionalString (ninja != null) "${pkgs.lib.getExe ninja}";
109109
CI_SKIP_TESTS = pkgs.lib.concatStringsSep "," (
110-
[ ]
111-
++ pkgs.lib.optionals useSharedAda [
112-
# Different versions of Ada affect the WPT tests
113-
"test-url"
114-
]
115-
++ pkgs.lib.optionals useSharedOpenSSL [
110+
pkgs.lib.optionals useSharedOpenSSL [
116111
# Path to the openssl.cnf is different from the expected one
117112
"test-strace-openat-openssl"
118113
]

test/wpt/test-url.js

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,14 @@
11
'use strict';
22

3+
const { hasIntl, skip } = require('../common');
4+
5+
if (!hasIntl) {
6+
skip('some tests requires Intl support');
7+
}
8+
if (process.config.variables.node_shared_ada) {
9+
skip('Different versions of Ada affect the WPT tests');
10+
}
11+
312
const { WPTRunner } = require('../common/wpt');
413

514
const runner = new WPTRunner('url');

0 commit comments

Comments
 (0)