ext/standard: array_filter $mode param follow-up#21100
Closed
Ayesh wants to merge 2 commits intophp:masterfrom
Closed
ext/standard: array_filter $mode param follow-up#21100Ayesh wants to merge 2 commits intophp:masterfrom
array_filter $mode param follow-up#21100Ayesh wants to merge 2 commits intophp:masterfrom
Conversation
Member
Author
|
I could use your review, @jorgsowa. Thank you. |
jorgsowa
reviewed
Jan 31, 2026
Contributor
jorgsowa
left a comment
jorgsowa
left a comment
There was a problem hiding this comment.
Thank you. I oversaw this constant, as I didn't want to introduce it first. Makes sense to me.
Contributor
|
@Ayesh you may need to regenerate stubs, because tests are failing. |
…RRAY_FILTER_USE_VALUE` In phpGH-15647, the `array_filter` function was changed to throw a `ValueError` exception when the `$mode` parameter receives an invalid. Additionally, it declares a new `ARRAY_FILTER_USE_VALUE`, assigned (`int 1`) to it. This changes the default value of the `array_filter` function's `$mode` parameter to use the new constant, changing it from `int $mode = 0` to `int $mode = ARRAY_FILTER_USE_KEY)`.
Ayesh
force-pushed
the
array_filter-follow-up
branch
from
654e9a9 to
8899b14
Compare
iluuu1994
approved these changes
Jan 31, 2026
Ayesh
added a commit
that referenced
this pull request
Feb 1, 2026
…RRAY_FILTER_USE_VALUE` In GH-15647, the `array_filter` function was changed to throw a `ValueError` exception when the `$mode` parameter receives an invalid. Additionally, it declares a new `ARRAY_FILTER_USE_VALUE`, assigned (`int 1`) to it. This changes the default value of the `array_filter` function's `$mode` parameter to use the new constant, changing it from `int $mode = 0` to `int $mode = ARRAY_FILTER_USE_KEY)`. Closes GH-21100.
Member
Author
|
Thank you @iluuu1994 and @jorgsowa. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In GH-15647, the
array_filterfunction was changed to throw aValueErrorexception when the$modeparameter receives an invalid.Additionally, it declares a new
ARRAY_FILTER_USE_VALUE, assigned (int 1) to it.This changes the default value of the
array_filterfunction's$modeparameter to use the new constant, changing it fromint $mode = 0toint $mode = ARRAY_FILTER_USE_KEY).Additionally, this adds the new constant to the
UPGRADINGfile.