Added ability to pass a console object to Cmd.print_to().#1592
Added ability to pass a console object to Cmd.print_to().#1592kmvanbrunt wants to merge 3 commits into3.xfrom
Conversation
|
🤖 Hi @kmvanbrunt, I've received your request, and I'm working on it now! You can track my progress in the logs for more details. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 3.x #1592 +/- ##
======================================
Coverage ? 99.23%
======================================
Files ? 21
Lines ? 4848
Branches ? 0
======================================
Hits ? 4811
Misses ? 37
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
🤖 I'm sorry @kmvanbrunt, but I was unable to process your request. Please see the logs for more details. |
| - Enhancements | ||
| - Added ability to pass a console object to `Cmd.print_to()`. This provides support for things | ||
| like wrapping a `print_to()` call in a `console.status()` or `console.capture()` context | ||
| manager. |
There was a problem hiding this comment.
We should document that the file parameter of cmd2.Cmd.print_to has been renamed to destination and that this is a potentially breaking change.
As such we should probably make it a 3.3.0 release instead of 3.2.3.
|
After this merges, we should cherry-pick changes to |
See #1578