Skip to content

gh-143414: Implement unique reference tracking for JIT, optimize unpacking of such tuples #144300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
reidenong wants to merge 12 commits into
base: main
Choose a base branch
from
+1,079 −876
Open

gh-143414: Implement unique reference tracking for JIT, optimize unpacking of such tuples #144300

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
e4b7f51
Add unique reference tracking to JIT, optimize tuple unpacking
reidenong Jan 28, 2026
b32a8e2
Merge branch 'main' into branch-unique-reference-tracking
reidenong Jan 28, 2026
7aeac0e
Regenerate cases
reidenong Jan 28, 2026
f8b7e4e
Fix unique tuple unpacking checks
reidenong Jan 28, 2026
37d7c4b
Implement _PyTuple_ExactDealloc
reidenong Jan 29, 2026
7df2176
Rename symbol
reidenong Jan 29, 2026
6f66c56
Merge branch 'main' into branch-unique-reference-tracking
reidenong Jan 30, 2026
b251825
Merge branch 'main' into branch-unique-reference-tracking
reidenong Jan 30, 2026
bcd5654
Regenerate cases
reidenong Jan 30, 2026
acfa737
Add alignment checking
reidenong Jan 31, 2026
a0fd9e2
Change JIT reference tags to 2 bit scheme
reidenong Jan 31, 2026
645776a
📜🤖 Added by blurb_it.
blurb-it[bot] Jan 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 28 additions & 5 deletions Include/internal/pycore_optimizer.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,9 +210,13 @@ static inline uint16_t uop_get_error_target(const _PyUOpInstruction *inst)


#define REF_IS_BORROWED 1
#define REF_IS_INVALID 2
#define REF_IS_UNIQUE 2
#define REF_IS_INVALID 3
#define REF_TAG_BITS 3

#define REF_GET_TAG(x) ((uintptr_t)(x) & (REF_TAG_BITS))
#define REF_CLEAR_TAG(x) ((uintptr_t)(x) & (~REF_TAG_BITS))

#define JIT_BITS_TO_PTR_MASKED(REF) ((JitOptSymbol *)(((REF).bits) & (~REF_TAG_BITS)))

static inline JitOptSymbol *
Expand All @@ -233,13 +237,32 @@ PyJitRef_Wrap(JitOptSymbol *sym)
static inline JitOptRef
PyJitRef_WrapInvalid(void *ptr)
{
return (JitOptRef){.bits=(uintptr_t)ptr | REF_IS_INVALID};
return (JitOptRef){.bits = REF_CLEAR_TAG((uintptr_t)ptr) | REF_IS_INVALID};
}

static inline bool
PyJitRef_IsInvalid(JitOptRef ref)
{
return (ref.bits & REF_IS_INVALID) == REF_IS_INVALID;
return REF_GET_TAG(ref.bits) == REF_IS_INVALID;
}

static inline JitOptRef
PyJitRef_MakeUnique(JitOptRef ref)
{
return (JitOptRef){ REF_CLEAR_TAG(ref.bits) | REF_IS_UNIQUE };
}

static inline bool
PyJitRef_IsUnique(JitOptRef ref)
{
return REF_GET_TAG(ref.bits) == REF_IS_UNIQUE;
}

static inline JitOptRef
PyJitRef_StripBorrowInfo(JitOptRef ref)
{
if (PyJitRef_IsUnique(ref)) return ref;
Copy link
Member

@Fidget-Spinner Fidget-Spinner Jan 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow PEP 7 and use curly braces around this.

return (JitOptRef){ .bits = REF_CLEAR_TAG(ref.bits) };
}

static inline JitOptRef
Expand All @@ -251,7 +274,7 @@ PyJitRef_StripReferenceInfo(JitOptRef ref)
static inline JitOptRef
PyJitRef_Borrow(JitOptRef ref)
{
return (JitOptRef){ .bits = ref.bits | REF_IS_BORROWED };
return (JitOptRef){ .bits = REF_CLEAR_TAG(ref.bits) | REF_IS_BORROWED };
}

static const JitOptRef PyJitRef_NULL = {.bits = REF_IS_BORROWED};
Expand All @@ -265,7 +288,7 @@ PyJitRef_IsNull(JitOptRef ref)
static inline int
PyJitRef_IsBorrowed(JitOptRef ref)
{
return (ref.bits & REF_IS_BORROWED) == REF_IS_BORROWED;
return REF_GET_TAG(ref.bits) == REF_IS_BORROWED;
}

extern bool _Py_uop_sym_is_null(JitOptRef sym);
Expand Down
2 changes: 2 additions & 0 deletions Include/internal/pycore_tuple.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@ extern PyStatus _PyTuple_InitGlobalObjects(PyInterpreterState *);

/* other API */

PyAPI_FUNC(void) _PyTuple_EmptyExactDealloc(PyObject *self);

#define _PyTuple_ITEMS(op) _Py_RVALUE(_PyTuple_CAST(op)->ob_item)

PyAPI_FUNC(PyObject *)_PyTuple_FromStackRefStealOnSuccess(const union _PyStackRef *, Py_ssize_t);
Expand Down
Loading
Loading