Skip to content

Commit 606f0f3

Browse files
committed
address bugbot comments
1 parent 089b8df commit 606f0f3

File tree

2 files changed

+2
-44
lines changed

2 files changed

+2
-44
lines changed

apps/sim/app/workspace/[workspaceId]/w/[workflowId]/hooks/use-block-output-fields.ts

Lines changed: 1 addition & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,7 @@
11
'use client'
22

33
import { useMemo } from 'react'
4-
import {
5-
getEffectiveBlockOutputs,
6-
getEvaluatorMetricOutputs,
7-
} from '@/lib/workflows/blocks/block-outputs'
4+
import { getEffectiveBlockOutputs } from '@/lib/workflows/blocks/block-outputs'
85
import type { SchemaField } from '@/app/workspace/[workspaceId]/w/[workflowId]/components/panel/components/editor/components/connection-blocks/components/field-item/field-item'
96
import { getBlock } from '@/blocks'
107
import { useSubBlockStore } from '@/stores/workflows/subblock/store'
@@ -123,31 +120,6 @@ export function useBlockOutputFields({
123120
return []
124121
}
125122

126-
// Handle evaluator blocks - use metrics if available
127-
if (blockType === 'evaluator') {
128-
const metricOutputs = getEvaluatorMetricOutputs(mergedSubBlocks)
129-
if (metricOutputs) {
130-
return Object.entries(metricOutputs).map(([name, output]) => ({
131-
name,
132-
type:
133-
output &&
134-
typeof output === 'object' &&
135-
'type' in output &&
136-
typeof output.type === 'string'
137-
? output.type
138-
: 'number',
139-
description:
140-
output &&
141-
typeof output === 'object' &&
142-
'description' in output &&
143-
typeof output.description === 'string'
144-
? output.description
145-
: undefined,
146-
}))
147-
}
148-
// Fall through to use blockConfig.outputs
149-
}
150-
151123
// Handle variables blocks - use variable assignments if available
152124
if (blockType === 'variables') {
153125
const variablesValue =

apps/sim/lib/copilot/tools/client/workflow/block-output-utils.ts

Lines changed: 1 addition & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,4 @@
1-
import {
2-
getEffectiveBlockOutputPaths,
3-
getEvaluatorMetricOutputs,
4-
} from '@/lib/workflows/blocks/block-outputs'
1+
import { getEffectiveBlockOutputPaths } from '@/lib/workflows/blocks/block-outputs'
52
import { normalizeName } from '@/executor/constants'
63
import { useVariablesStore } from '@/stores/panel/variables/store'
74
import type { Variable } from '@/stores/panel/variables/types'
@@ -97,17 +94,6 @@ export function computeBlockOutputPaths(block: BlockState, ctx: WorkflowContext)
9794
return ['results', ...insidePaths]
9895
}
9996

100-
if (block.type === 'evaluator') {
101-
const metricOutputs = getEvaluatorMetricOutputs(mergedSubBlocks)
102-
if (metricOutputs) {
103-
return Object.keys(metricOutputs)
104-
}
105-
return getEffectiveBlockOutputPaths(block.type, mergedSubBlocks, {
106-
triggerMode: Boolean(block.triggerMode),
107-
preferToolOutputs: !block.triggerMode,
108-
})
109-
}
110-
11197
if (block.type === 'variables') {
11298
const variablesValue = getSubBlockValue(blocks, subBlockValues, block.id, 'variables')
11399
if (variablesValue && Array.isArray(variablesValue) && variablesValue.length > 0) {

0 commit comments

Comments
 (0)