Skip to content

Commit a9e32fb

Browse files
committed
Adds shortcut key to Cancel buttons
1 parent 1796c2f commit a9e32fb

File tree

1 file changed

+15
-3
lines changed

1 file changed

+15
-3
lines changed

apps/webapp/app/components/query/QueryEditor.tsx

Lines changed: 15 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -572,7 +572,13 @@ export function QueryEditor({
572572
<NavBar>
573573
<PageTitle title={`Add chart to ${mode.dashboardName}`} />
574574
<PageAccessories>
575-
<Button variant="tertiary/small" onClick={onClose}>
575+
<Button
576+
variant="secondary/small"
577+
onClick={onClose}
578+
shortcut={{ key: "esc" }}
579+
shortcutPosition="before-trailing-icon"
580+
// className="pl-1"
581+
>
576582
Cancel
577583
</Button>
578584
</PageAccessories>
@@ -583,7 +589,13 @@ export function QueryEditor({
583589
<NavBar>
584590
<PageTitle title={`Editing "${mode.widgetName}"`} />
585591
<PageAccessories>
586-
<Button variant="tertiary/small" onClick={onClose}>
592+
<Button
593+
variant="secondary/small"
594+
onClick={onClose}
595+
shortcut={{ key: "esc" }}
596+
shortcutPosition="before-trailing-icon"
597+
// className="pl-1"
598+
>
587599
Cancel
588600
</Button>
589601
</PageAccessories>
@@ -1006,7 +1018,7 @@ function QueryTitle({
10061018
</InputGroup>
10071019
<DialogFooter>
10081020
<DialogClose asChild>
1009-
<Button variant="tertiary/medium">Cancel</Button>
1021+
<Button variant="secondary/medium">Cancel</Button>
10101022
</DialogClose>
10111023
<Button type="submit" variant="primary/medium" disabled={!renameValue.trim()}>
10121024
Save

0 commit comments

Comments
 (0)