docs: add small nuance regarding the onCancel hook#3117
docs: add small nuance regarding the onCancel hook#3117RobbyUitbeijerse wants to merge 2 commits intotriggerdotdev:mainfrom
Conversation
|
|
Hi @RobbyUitbeijerse, thanks for your interest in contributing! This project requires that pull request authors are vouched, and you are not in the list of vouched users. This PR will be closed automatically. See https://github.com/triggerdotdev/trigger.dev/blob/main/CONTRIBUTING.md for more details. |
|
Caution Review failedThe pull request is closed. ℹ️ Recent review infoConfiguration used: Repository UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
WalkthroughA documentation update to Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| ``` | ||
|
|
||
| <Info> | ||
| The `onCancel` hook doesn’t fire if the task being canceled isn’t currently executing (for example, it won’t run for tasks hat haven't started or tasks waiting at a waitpoint). |
There was a problem hiding this comment.
🟡 Typo: "tasks hat haven't started" should be "tasks that haven't started"
The newly added <Info> block contains a typo on line 534: "tasks hat haven't started" is missing the letter "t" in "that".
Details
The text reads:
it won't run for tasks hat haven't started
It should read:
it won't run for tasks that haven't started
Impact: Minor documentation typo visible to all users reading the docs.
| The `onCancel` hook doesn’t fire if the task being canceled isn’t currently executing (for example, it won’t run for tasks hat haven't started or tasks waiting at a waitpoint). | |
| The `onCancel` hook doesn't fire if the task being canceled isn't currently executing (for example, it won't run for tasks that haven't started or tasks waiting at a waitpoint). | |
Was this helpful? React with 👍 or 👎 to provide feedback.
Thanks @isshaddad for the explanation on this one, I figured it could save some future questions to have this explicitly stated somewhere.
✅ Checklist