Skip to content

fix: Tool executes rendering using title field #4833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shaohuzhang1 merged 1 commit into from
Mar 2, 2026
+1 −1
Merged

fix: Tool executes rendering using title field #4833

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ui/src/components/markdown/tool-calls-render/index.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<div class="flex" style="flex-wrap: nowrap; align-items: center">
<el-avatar class="avatar-gradient mr-8" style="height: 20px; width: 20px" shape="square">
<img :src="toolCallsContent.icon || defaultIcon" /> </el-avatar
>工具执行
>{{ toolCallsContent.title || '工具执行' }}工具执行
</div>
</template>
<Content :content="toolCallsContent"></Content>
Copy link
Contributor Author

@shaohuzhang1 shaohuzhang1 Mar 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The provided code snippet contains a few potential issues that could be addressed for better readability and functionality:

  1. Incorrect Use of Template Literals: The use of template literals in the div element might not be necessary for this simple usage scenario. You can simply concatenate strings directly.

  2. Repetitive Text: The text "工具执行" appears twice consecutively within the HTML structure. This is unnecessary redundancy and should be removed to improve maintainability.

Here's the revised version of the code with these improvements:

@@ -5,7 +5,7 @@
   <div class="flex" style="flex-wrap: nowrap; align-items: center">
     <el-avatar class="avatar-gradient mr-8" style="height: 20px; width: 20px" shape="square">
       <img :src="toolCallsContent.icon || defaultIcon" />
     </el-avatar> {{ toolCallsContent.title || '工具执行' }}
   </div>
 </template>

Key Improvements:

  1. Removed Redundant Text: Removed the second instance of "工具执行".
  2. Direct Concatenation: Used straightforward string concatenation instead of template literals for the title.

These changes make the code cleaner and more readable while maintaining its functionality.

Expand Down