Remove DPO (Direct Preference Optimization) feature#3064
Open
ecnal-cienet wants to merge 1 commit intomainfrom
Open
Remove DPO (Direct Preference Optimization) feature#3064ecnal-cienet wants to merge 1 commit intomainfrom
ecnal-cienet wants to merge 1 commit intomainfrom
Conversation
f13c153 to
67c601e
Compare
Collaborator
|
Is this removal indicating the integration with Tunix DPO? |
Collaborator
Author
|
Hi Ranran, |
shralex
approved these changes
Feb 11, 2026
67c601e to
0e6b29d
Compare
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
0e6b29d to
5e37636
Compare
5e37636 to
fd5ad68
Compare
A9isha
approved these changes
Feb 11, 2026
Collaborator
A9isha
left a comment
There was a problem hiding this comment.
LGTM, just one small comment - thank you Charles!
| Args: | ||
| _loss_fn: The loss function to differentiate. Its signature is expected | ||
| to be: `(model, config, data, dropout_rng, params, *extra_args, is_train=True)`. | ||
| to be: `(model, config, data, dropout_rng, params, is_train=True)`. |
Collaborator
There was a problem hiding this comment.
why are we removing the *extra_args here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Summary
Changes
Deleted Files
src/maxtext/trainers/post_train/dpo/dpo_utils.py- core DPO loss implementationsrc/MaxText/configs/dpo.yml- DPO configuration filetests/end_to_end/tpu/test_dpo.sh- DPO end-to-end testModified Files
Training Pipeline:
src/MaxText/train.py- removed DPO loss integration, reference param handling, and DPO metricssrc/maxtext/utils/train_utils.py- removed DPO state restoration logicsrc/MaxText/gradient_accumulation.py- removedextra_dpo_argsparameterData Pipelines:
src/MaxText/input_pipeline/_grain_data_processing.py- removeddpo_preprocessing_pipelineand DPO branchessrc/MaxText/input_pipeline/_tfds_data_processing.py- removeduse_dpoparametersrc/MaxText/input_pipeline/_hf_data_processing.py- removeduse_dpoparameterConfiguration:
src/MaxText/configs/base.yml- removeduse_dpo,dpo_label_smoothing,dpo_betaparameterssrc/MaxText/configs/types.py- removed DPO fields fromFineTuningclassUtilities:
src/maxtext/common/metric_logger.py- removed DPO reward accuracy metricssrc/maxtext/utils/maxtext_utils.py- removed DPO FLOPs calculationsrc/MaxText/__init__.py- removeddpo_utilsexportTests:
tests/unit/configs_test.py- removed dpo.yml from config validation teststests/unit/sft_data_processing_test.py- removeduse_dpoargumentOther:
src/MaxText/experimental/rl/grpo_trainer.py- removed errantuse_dpocheckTests
Verified synthetic data training runs successfully with:
Log: view (no DPO related params at all)
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.