Fix crash on shouldCallGetNode in tests#511
Open
GertjanReynaert wants to merge 2 commits intoAPSL:masterfrom
Open
Fix crash on shouldCallGetNode in tests#511GertjanReynaert wants to merge 2 commits intoAPSL:masterfrom
shouldCallGetNode in tests#511GertjanReynaert wants to merge 2 commits intoAPSL:masterfrom
Conversation
In our test suite `Platform.constants` is an empty object. This was making the previous `!Platform.constants` check pass, but caused a crash when trying to access `major` on `reactNativeVersion`. This fix correctly checks if `reactNativeVersion` is present and is an object to avoid this issue.
|
This is a legitimate issue breaking all test suites on the latest versions of React Native. |
|
Can second this is a huge issue for me too and this fixes it for me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In our test suite (jest + react-native-testing-library)
Platform.constantsis an empty object. This was making the previous!Platform.constantscheck pass, but caused a crash when trying to accessmajoronreactNativeVersion.This fix correctly checks if
reactNativeVersionis present and is an object to avoid this issue.