Skip to content

Index names consistently set to "alt" for alternatives files#1018

Merged
jpn-- merged 14 commits intoActivitySim:mainfrom
RSGInc:alt_file_formatting
Jan 8, 2026
Merged

Index names consistently set to "alt" for alternatives files#1018
jpn-- merged 14 commits intoActivitySim:mainfrom
RSGInc:alt_file_formatting

Conversation

@dhensle
Copy link
Contributor

@dhensle dhensle commented Nov 13, 2025

Fix for #846.

In addition to CI tests, also successfully ran the SANDAG (cropped) estimation data through estimation mode and confirmed the creation of school escorting and joint tour frequency and composition EDBs.

@dhensle dhensle marked this pull request as draft November 13, 2025 18:02
@dhensle dhensle marked this pull request as ready for review November 13, 2025 18:15
@jpn-- jpn-- added this to Phase 11 Nov 13, 2025
@jpn-- jpn-- moved this to Tasked in Phase 11 Nov 13, 2025
@jpn-- jpn-- self-requested a review November 13, 2025 18:33
@jpn--
Copy link
Member

jpn-- commented Dec 2, 2025

This looks fine to me. @dhensle Just one (new) thing to do: please add a section to docs/dev-guide/changes.md about this change, under the Upcoming Changes section at the top.

@jpn-- jpn-- moved this from Tasked to Under Review in Phase 11 Dec 2, 2025
@dhensle dhensle self-assigned this Dec 2, 2025
@dhensle
Copy link
Contributor Author

dhensle commented Dec 16, 2025

@jpn-- I have update the change log for your review. Also, I tried to repair the progressive mtc test by unzipping, changing the Alt column name to alt in the school escorting bundle that was failing, and re-zipped it back up, but now I am getting some weird error about not finding the input checker log. Is there something different you do to create the zip file that maybe I messed up?

@jpn--
Copy link
Member

jpn-- commented Dec 18, 2025

@dhensle Typically when I need to regenerate the progressive tests it's because the numbers have changed slightly, so I just delete the regression targets and re-run, which should automatically regenerate the files. But for a change like this where the numbers are all the same and it's just a header that's changed, what you describe should work -- and I'm surprised it didn't.

@jpn-- jpn-- merged commit 6266ce4 into ActivitySim:main Jan 8, 2026
1 check passed
@github-project-automation github-project-automation bot moved this from Under Review to Done in Phase 11 Jan 8, 2026
dhensle added a commit to RSGInc/activitysim that referenced this pull request Mar 4, 2026
commit c031c8b
Author: David Hensle <hensle93@gmail.com>
Date:   Fri Feb 13 15:48:35 2026 -0800

    adding ignore list to skim load for unused skims

commit 83613b2
Author: Copilot <198982749+Copilot@users.noreply.github.com>
Date:   Thu Feb 12 16:30:58 2026 -0600

    Fix Sphinx currentmodule directive for location choice documentation (ActivitySim#1034)

    * Initial plan

    * Fix currentmodule directive in work_location_choice.md and school_location_choice.md

    Co-authored-by: jpn-- <1036626+jpn--@users.noreply.github.com>

    ---------

    Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
    Co-authored-by: jpn-- <1036626+jpn--@users.noreply.github.com>

commit aa58cc4
Author: David Hensle <51132108+dhensle@users.noreply.github.com>
Date:   Fri Jan 16 03:31:07 2026 +1100

    Fix for zones reopening in simulation-based constraint mechanism for work/school location choice (ActivitySim#1028)

    * addresses issue with zones reopening after being closed in shadow_pricing

    * addresses issue with zones reopening after being closed in shadow_pricing

    * adding shadow price regression values

    * updating change log

    ---------

    Co-authored-by: juangacosta <juan.acosta@rsginc.com>

commit 6266ce4
Author: David Hensle <51132108+dhensle@users.noreply.github.com>
Date:   Thu Jan 8 10:26:48 2026 -0800

    Index names consistently set to "alt" for alternatives files (ActivitySim#1018)

    * "alt" now used as index in all alternatives modules

    * formatting

    * minor commenting

    * using stable sorting for unit test

    * adding to change log

    * updating school escort bundle Alt to alt

    * typo

    * Revert "updating school escort bundle Alt to alt"

    This reverts commit 625f685.

    * regenerate pipeline

    ---------

    Co-authored-by: juangacosta <juan.acosta@rsginc.com>
    Co-authored-by: Jeffrey Newman <jeff@driftless.xyz>

commit 0811191
Author: Jeffrey Newman <jeff@driftless.xyz>
Date:   Thu Jan 8 11:11:43 2026 -0600

    Repair CDAP estimation (ActivitySim#1026)

    * fix error in CDAP estimation model construction

    * update tests for CDAP

    * fix the other test file

    * add to changes.md

    * note on possible fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants