ITS: GPU: reverse destruction order to fix crash#14863
Merged
davidrohr merged 1 commit intoAliceO2Group:devfrom Nov 27, 2025
Merged
ITS: GPU: reverse destruction order to fix crash#14863davidrohr merged 1 commit intoAliceO2Group:devfrom
davidrohr merged 1 commit intoAliceO2Group:devfrom
Conversation
Contributor
|
REQUEST FOR PRODUCTION RELEASES: This will add The following labels are available |
davidrohr
previously approved these changes
Nov 27, 2025
Collaborator
|
Error while checking build/O2/fullCI_slc9 for 3bee3f7 at 2025-11-27 14:29: Full log here. |
Collaborator
|
Error while checking build/O2/fullCI_slc9 for 22bec1f at 2025-11-27 16:42: Full log here. |
Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
f3sch
force-pushed
the
its/gpu/fix_dest
branch
from
22bec1f to
285872c
Compare
Collaborator
|
Error while checking build/O2/fullCI_slc9 for 285872c at 2025-11-27 22:27: Full log here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes crashes in the GPU test:
The issue is that after #14681, I relied on the framework pointer being around when calling the TimeFrame destructor, which is fine when using the gpu framework held by the its reco workflow (
o2-its-reco-workflow --use-gpu-workflow). However, running in the real gpu-reco-workflow this is not the case. The framework allocator was destructed before the destructor of the TimeFrame was called (c++ clears them in reverse member declaration order). The solution is simply to reverse the member order.