[PWGHF] Add QA histograms to XicToXiPiPi candidate selector#11982
[PWGHF] Add QA histograms to XicToXiPiPi candidate selector#11982fgrosa merged 4 commits intoAliceO2Group:masterfrom
Conversation
|
O2 linter results: ❌ 0 errors, |
fgrosa
left a comment
There was a problem hiding this comment.
Just a couple of minor comments from my side!
| } | ||
|
|
||
| // add histograms to registry | ||
| registry.add("hVertexerType", "Use DCAFitter or KFParticle;;entries", {HistType::kTH1F, {{2, -0.5, 1.5}}}); |
There was a problem hiding this comment.
Use TH1D for 1D histograms to avoid truncation of bin content in case of large number of entries
| registry.add("hVertexerType", "Use DCAFitter or KFParticle;;entries", {HistType::kTH1F, {{2, -0.5, 1.5}}}); | |
| registry.add("hVertexerType", "Use DCAFitter or KFParticle;;entries", {HistType::kTH1D, {{2, -0.5, 1.5}}}); |
| registry.add("hVertexerType", "Use DCAFitter or KFParticle;;entries", {HistType::kTH1F, {{2, -0.5, 1.5}}}); | ||
| registry.get<TH1>(HIST("hVertexerType"))->GetXaxis()->SetBinLabel(1 + aod::hf_cand::VertexerType::DCAFitter, "DCAFitter"); | ||
| registry.get<TH1>(HIST("hVertexerType"))->GetXaxis()->SetBinLabel(1 + aod::hf_cand::VertexerType::KfParticle, "KFParticle"); | ||
| registry.add("hCandCounter", "hCandCounter", {HistType::kTH1F, {{4, -0.5, 3.5}}}); |
There was a problem hiding this comment.
| registry.add("hCandCounter", "hCandCounter", {HistType::kTH1F, {{4, -0.5, 3.5}}}); | |
| registry.add("hCandCounter", "hCandCounter", {HistType::kTH1D, {{4, -0.5, 3.5}}}); |
|
Hi @fgrosa, thank you for your comments! I also split the I run am running a local test at the moment and then will update the PR accordingly. |
@JaeYoonCHO @sh-lim @klsmith15k