[PWGCF] FemtoUniverse: Add function to pair MCTruth particles#13376
Merged
[PWGCF] FemtoUniverse: Add function to pair MCTruth particles#13376
Conversation
prchakra
requested review from
alibuild,
ariedel-cern,
glromane,
lauraser,
lgraczykCern,
otonvd,
shouqiye,
victor-gonzalez and
zchochul
as code owners
|
O2 linter results: ❌ 84 errors, |
vkucera
reviewed
Oct 14, 2025
| struct femtoUniversePairTaskTrackTrackSpherHarMultKtExtended { | ||
|
|
||
| Service<o2::framework::O2DatabasePDG> pdg; | ||
| Service<o2::framework::O2DatabasePDG> pdgMC; |
Collaborator
There was a problem hiding this comment.
Why are you adding a second identical service member?
Comment on lines
+719
to
+720
| /// Histogramming same event | ||
| if ((ContType == 1 || ContType == 2) && fillQA) { |
Collaborator
There was a problem hiding this comment.
What do values 1 and 2 mean? Name them.
Collaborator
Author
There was a problem hiding this comment.
Do you mean to add a comment about them?
Collaborator
There was a problem hiding this comment.
No. Please read the O2 linter error messages.
Comment on lines
+772
to
+773
| switch (ContType) { | ||
| case 2: { |
| auto thegroupPartsOne = partsOneMCTruth->sliceByCached(aod::femtouniverseparticle::fdCollisionId, col.globalIndex(), cache); | ||
| auto thegroupPartsTwo = partsTwoMCTruth->sliceByCached(aod::femtouniverseparticle::fdCollisionId, col.globalIndex(), cache); | ||
| bool fillQA = true; | ||
| randgen = new TRandom2(0); |
Collaborator
Author
There was a problem hiding this comment.
It is used in
Collaborator
There was a problem hiding this comment.
The line you are referring is in another function.
ThePhDane
pushed a commit
to ThePhDane/O2Physics
that referenced
this pull request
Nov 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.