[PWGEM] Add FV0 QVectors to EM event#13612
Conversation
mhemmer-cern
commented
Oct 30, 2025
mhemmer-cern
commented
- Add the FV0 QVector values to the EM event QVector table version _001
- Keep old version as _000
- Add converter task to convert from _000 to _001 in new Core folder directly under PWGEM, since this is a core task that effects both PAG.
- Ensure IWYU pragma for all touched files
mhemmer-cern
requested review from
alibuild,
dsekihat,
feisenhu,
hscheid,
ivorobye,
m-c-danisch,
mikesas,
novitzky and
rbailhac
as code owners
|
O2 linter results: ❌ 121 errors, |
|
Do you really need Q vector of FV0A? The Q vector of FV0A is not stored on the purpose to reduce data size, because we have FT0A. EP resolution can be calculated via 3 sub events with [FT0A, FT0C, BTot] or [FT0M, BPos, BNeg]. We don't store unused variable. |
It was brought to my attention from the PWGCF that FT0C with FT0A and FV0 is preferred, that's why I want to add FV0. |
dsekihat
left a comment
dsekihat
left a comment
There was a problem hiding this comment.
Can you move the converter to Dilepton/Tasks/Converters/ ? The rest is OK.
I actually would prefer if we keep it there and at some point start moving code that is used in both PAGs to migrate to PWGEM/Core, PWGEM/Utils and PWGEM/DataModel. |
Let's keep consistency for now under Dilepton/Tasks/Converters/. |
- Add the FV0 QVector values to the EM event QVector table version _001 - Keep old version as _000 - Add converter task to convert from _000 to _001 - Ensure IWYU pragma for all touched files
mhemmer-cern
force-pushed
the
PWGEM-include-FV0
branch
from
90dc5ba to
455ad70
Compare
@dsekihat Converters are by definition table producers. It makes no sense to put them in the Tasks directory. Please respect the repository structure. |
|
Let me take care of them. |
Thanks! |
3 participants
