[Common] Fix problems found by Cppcheck

[vkucera]

Please double-check the changes carefully.

[github-actions]

O2 linter results: ❌ 146 errors, ⚠️ 144 warnings, 🔕 47 disabled

[vkucera]

@ddobrigk Which PDG code should be used to fix the duplicated condition in Common/TableProducer/selectionStudyTable.cxx?

[vkucera]

@ddobrigk Ping

[ddobrigk]

@ddobrigk Which PDG code should be used to fix the duplicated condition in Common/TableProducer/selectionStudyTable.cxx?

Sorry, overlooked this. That second loop should be removed, as it is spurious (in a part of the code that was in the end not used for anything significnat yet, so no big deal)

[vkucera]

@ddobrigk Which PDG code should be used to fix the duplicated condition in Common/TableProducer/selectionStudyTable.cxx?

Sorry, overlooked this. That second loop should be removed, as it is spurious (in a part of the code that was in the end not used for anything significnat yet, so no big deal)

I removed the duplicated block.

[ddobrigk]

Can someone from the TPC crew perhaps just take another look at the loop that was touched by this PR? @amaringarcia - thanks!

[lubynets]

Can someone from the TPC crew perhaps just take another look at the loop that was touched by this PR? @amaringarcia - thanks!

Dear All,
I had a look at the PR on Ana's request. It looks fine to me: the PR either fixes c++ issues without change of the observed behavior, or changes the observed behavior in a correct side.
The only thing which is not obvious to me without knowledge of the context is the removed loop. But since David indicated that loop as spurious, probably the removal is fine.
Or was your, @ddobrigk, question related to a specific loop in the PR, in particular the logic of the mentioned one?