[PWGJE,PWGUD] adding upc selections to JE framework

[nzardosh]

No description provided.

[github-actions]

O2 linter results: ❌ 51 errors, ⚠️ 75 warnings, 🔕 0 disabled

[nzardosh]

Dear UD experts, I have added a small modification to your isSelected function which allows one to optionally extract a vector with the amplitude values of the FIT detectors in bcs compatible with a UPC event. These can then be used later by analysers to make tighter event selections. However the functionality of the task should be unchanged by this addition

[vkucera]

This should be fixed

[nzardosh]

i will fix it in a seperate PR

[nzardosh]

@rolavick and @amatyja can you take a look please?

[fjonasALICE]

there is a copy paste error. The Laben should be "upcMinNTracks"

[nzardosh]

thanks

[fjonasALICE]

vector creation and destruction in for each collision creates unnecessary heap allocation overhead. Consider instead something like:

// Outside loop
std::vector<float> amplitudesFV0;
// ... define others ...

for (auto const& collision : collisions) {
    if (collision.isCollisionSelected()) {
        amplitudesFV0.clear();
        // ... clear others ...
        
        // Copy data
        auto amplitudesFV0Span = collision.amplitudesFV0();
        amplitudesFV0.assign(amplitudesFV0Span.begin(), amplitudesFV0Span.end()); // More efficient than back_inserter
        
        // ...
    }
}

[nzardosh]

the problem with this is that the task is flirting with the 100 member limit as it is

[vkucera]

How is this related to members?

[vkucera]

@nzardosh Don't waste CPU.

[rolavick]

Dear @nzardosh, the modification of the UD part looks ok to me, so I approve, but one question on the usage: Do you put some constraints on the bcrange? I wonder if one can hit a large range, and then the vectors would go large, which may cause some memory issues.
Roman

[nzardosh]

Dear @nzardosh, the modification of the UD part looks ok to me, so I approve, but one question on the usage: Do you put some constraints on the bcrange? I wonder if one can hit a large range, and then the vectors would go large, which may cause some memory issues. Roman

Dear @rolavick thanks! If I understand correctly this upcCuts.SetNDtcoll(config.upcBCRangeTimeWindow); should set the range? or is there a better way you would recommend i can do it?

thanks

[rolavick]

Could you please incorporate this MegaLinter error
PWGUD/Core/SGSelector.h:65: Add #include for vector<> [build/include_what_you_use] [4]
thanks

[alibuild]

Auto-approving on behalf of @nzardosh.