[PWGCF] Adding an option to reject either the inner or the outer ring of the FT0 detectors#14296
[PWGCF] Adding an option to reject either the inner or the outer ring of the FT0 detectors#14296MartijnLaarhoven wants to merge 14 commits intoAliceO2Group:masterfrom
Conversation
Added option to reject the inside or the outside of the detector ring of FT0
Added option to reject the inside or the outside of the detector ring of FT0
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
making the rejection of the rejection of part of the detector more distinctive
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
MartijnLaarhoven
requested review from
alibuild,
ariedel-cern,
glromane,
lauraser,
lgraczykCern,
otonvd,
prchakra,
shouqiye,
victor-gonzalez and
zchochul
as code owners
|
O2 linter results: ❌ 0 errors, |
github-actions
bot
changed the title
There was a problem hiding this comment.
Pull request overview
This PR adds configuration options to selectively reject either the inner or outer ring channels of the FT0A and FT0C detectors in long-range dihadron correlation analysis. This functionality allows for systematic studies of detector response and helps in understanding contributions from different detector regions.
Key Changes:
- Added four new boolean configuration options to enable rejection of inner/outer rings for FT0A and FT0C detectors independently
- Introduced a DetectorChannels enum defining the channel ID ranges for inner and outer rings of both detectors
- Implemented rejection logic in the getChannel function by setting amplitude to 0 for channels in the rejected rings
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| enum DetectorChannels { | ||
| kFT0AInnerRingMin = 0, | ||
| kFT0AInnerRingMax = 31, | ||
| kFT0AOuterRingMin = 32, | ||
| kFT0AOuterRingMax = 95, | ||
| kFT0CInnerRingMin = 96, | ||
| kFT0CInnerRingMax = 143, | ||
| kFT0COuterRingMin = 144, | ||
| kFT0COuterRingMax = 207 | ||
| }; |
There was a problem hiding this comment.
The DetectorChannels enum lacks documentation explaining the meaning of these channel ranges. Consider adding a comment block above the enum describing the FT0 detector geometry and how these channel ranges correspond to the inner and outer rings of the FT0A and FT0C detectors.
| O2_DEFINE_CONFIGURABLE(cfgRejectFT0AInside, bool, false, "Rejection of inner ring channels of the FT0A detector") | ||
| O2_DEFINE_CONFIGURABLE(cfgRejectFT0AOutside, bool, false, "Rejection of outer ring channels of the FT0A detector") | ||
| O2_DEFINE_CONFIGURABLE(cfgRejectFT0CInside, bool, false, "Rejection of inner ring channels of the FT0C detector") | ||
| O2_DEFINE_CONFIGURABLE(cfgRejectFT0COutside, bool, false, "Rejection of outer ring channels of the FT0C detector") |
There was a problem hiding this comment.
The configuration allows enabling both inner and outer ring rejection simultaneously (e.g., both cfgRejectFT0AInside and cfgRejectFT0AOutside can be true), which would reject all channels of a detector. Consider adding validation logic to prevent this configuration, or document that this is an intentional feature if the use case exists.
|
Please, don't merge the changes into the master. That pollutes PR history |
2 participants
Adding an option to reject either the inner or the outer ring of both the FT0 detectors individually.