chore(deps): bump the npm_and_yarn group across 2 directories with 11 updates#6
Open
dependabot[bot] wants to merge 1 commit intomainfrom
Open
chore(deps): bump the npm_and_yarn group across 2 directories with 11 updates#6dependabot[bot] wants to merge 1 commit intomainfrom
dependabot[bot] wants to merge 1 commit intomainfrom
Conversation
… updates Bumps the npm_and_yarn group with 11 updates in the / directory: | Package | From | To | | --- | --- | --- | | [glob](https://github.com/isaacs/node-glob) | `10.4.5` | `10.5.0` | | [tar](https://github.com/isaacs/node-tar) | `7.5.1` | `7.5.8` | | [@modelcontextprotocol/sdk](https://github.com/modelcontextprotocol/typescript-sdk) | `1.15.1` | `1.26.0` | | [diff](https://github.com/kpdecker/jsdiff) | `7.0.0` | `8.0.3` | | [undici](https://github.com/nodejs/undici) | `7.15.0` | `7.18.2` | | [ajv](https://github.com/ajv-validator/ajv) | `8.17.1` | `8.18.0` | | [js-yaml](https://github.com/nodeca/js-yaml) | `3.14.1` | `3.14.2` | | [minimatch](https://github.com/isaacs/minimatch) | `3.1.2` | `3.1.5` | | [jws](https://github.com/brianloveswords/node-jws) | `4.0.0` | `4.0.1` | | [rollup](https://github.com/rollup/rollup) | `4.44.0` | `4.59.0` | | [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) | `7.1.9` | `7.3.1` | Bumps the npm_and_yarn group with 1 update in the /packages/core directory: [diff](https://github.com/kpdecker/jsdiff). Updates `glob` from 10.4.5 to 10.5.0 - [Changelog](https://github.com/isaacs/node-glob/blob/main/changelog.md) - [Commits](isaacs/node-glob@v10.4.5...v10.5.0) Updates `tar` from 7.5.1 to 7.5.8 - [Release notes](https://github.com/isaacs/node-tar/releases) - [Changelog](https://github.com/isaacs/node-tar/blob/main/CHANGELOG.md) - [Commits](isaacs/node-tar@v7.5.1...v7.5.8) Updates `@modelcontextprotocol/sdk` from 1.15.1 to 1.26.0 - [Release notes](https://github.com/modelcontextprotocol/typescript-sdk/releases) - [Commits](modelcontextprotocol/typescript-sdk@1.15.1...v1.26.0) Updates `diff` from 7.0.0 to 8.0.3 - [Changelog](https://github.com/kpdecker/jsdiff/blob/master/release-notes.md) - [Commits](kpdecker/jsdiff@7.0.0...v8.0.3) Updates `undici` from 7.15.0 to 7.18.2 - [Release notes](https://github.com/nodejs/undici/releases) - [Commits](nodejs/undici@v7.15.0...v7.18.2) Updates `ajv` from 8.17.1 to 8.18.0 - [Release notes](https://github.com/ajv-validator/ajv/releases) - [Commits](ajv-validator/ajv@v8.17.1...v8.18.0) Updates `js-yaml` from 3.14.1 to 3.14.2 - [Changelog](https://github.com/nodeca/js-yaml/blob/master/CHANGELOG.md) - [Commits](nodeca/js-yaml@3.14.1...3.14.2) Updates `minimatch` from 3.1.2 to 3.1.5 - [Changelog](https://github.com/isaacs/minimatch/blob/main/changelog.md) - [Commits](isaacs/minimatch@v3.1.2...v3.1.5) Updates `jws` from 4.0.0 to 4.0.1 - [Release notes](https://github.com/brianloveswords/node-jws/releases) - [Changelog](https://github.com/auth0/node-jws/blob/master/CHANGELOG.md) - [Commits](auth0/node-jws@v4.0.0...v4.0.1) Updates `rollup` from 4.44.0 to 4.59.0 - [Release notes](https://github.com/rollup/rollup/releases) - [Changelog](https://github.com/rollup/rollup/blob/master/CHANGELOG.md) - [Commits](rollup/rollup@v4.44.0...v4.59.0) Updates `vite` from 7.1.9 to 7.3.1 - [Release notes](https://github.com/vitejs/vite/releases) - [Changelog](https://github.com/vitejs/vite/blob/main/packages/vite/CHANGELOG.md) - [Commits](https://github.com/vitejs/vite/commits/v7.3.1/packages/vite) Updates `diff` from 7.0.0 to 8.0.3 - [Changelog](https://github.com/kpdecker/jsdiff/blob/master/release-notes.md) - [Commits](kpdecker/jsdiff@7.0.0...v8.0.3) --- updated-dependencies: - dependency-name: glob dependency-version: 10.5.0 dependency-type: direct:production dependency-group: npm_and_yarn - dependency-name: tar dependency-version: 7.5.8 dependency-type: direct:production dependency-group: npm_and_yarn - dependency-name: "@modelcontextprotocol/sdk" dependency-version: 1.26.0 dependency-type: direct:production dependency-group: npm_and_yarn - dependency-name: diff dependency-version: 8.0.3 dependency-type: direct:production dependency-group: npm_and_yarn - dependency-name: undici dependency-version: 7.18.2 dependency-type: direct:production dependency-group: npm_and_yarn - dependency-name: ajv dependency-version: 8.18.0 dependency-type: direct:production dependency-group: npm_and_yarn - dependency-name: js-yaml dependency-version: 3.14.2 dependency-type: indirect dependency-group: npm_and_yarn - dependency-name: minimatch dependency-version: 3.1.5 dependency-type: indirect dependency-group: npm_and_yarn - dependency-name: jws dependency-version: 4.0.1 dependency-type: indirect dependency-group: npm_and_yarn - dependency-name: rollup dependency-version: 4.59.0 dependency-type: indirect dependency-group: npm_and_yarn - dependency-name: vite dependency-version: 7.3.1 dependency-type: indirect dependency-group: npm_and_yarn - dependency-name: diff dependency-version: 8.0.3 dependency-type: direct:production dependency-group: npm_and_yarn ... Signed-off-by: dependabot[bot] <support@github.com>
Comment on lines
44
to
54
| "chardet": "^2.1.0", | ||
| "diff": "^7.0.0", | ||
| "diff": "^8.0.3", | ||
| "dotenv": "^17.1.0", | ||
| "fast-levenshtein": "^2.0.6", | ||
| "fast-uri": "^3.0.6", | ||
| "fdir": "^6.4.6", | ||
| "fzf": "^0.5.2", | ||
| "glob": "^10.4.5", | ||
| "glob": "^13.0.6", | ||
| "google-auth-library": "^9.11.0", | ||
| "html-to-text": "^9.0.5", | ||
| "https-proxy-agent": "^7.0.6", |
There was a problem hiding this comment.
Bug: The upgrade of glob to v13 is a breaking change. The code uses the stat: true option, which is removed in v13, causing file sorting by modification time to fail.
Severity: CRITICAL
Suggested Fix
The glob dependency version in packages/core/package.json should be aligned with the other packages in the monorepo, which is 10.5.0. This avoids the breaking change introduced in glob v13 and ensures the stat: true option continues to work as expected.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: packages/core/package.json#L42-L54
Potential issue: The `glob` dependency in `packages/core/package.json` is upgraded to
v13.0.6, which introduces a breaking change. The code in
`packages/core/src/tools/glob.ts` calls `glob()` with the `stat: true` option. This
option was removed in `glob` v8 and later. The application relies on this option to
populate the `mtimeMs` property on file entries, which is then used by the
`sortFileEntries()` function to sort files by modification time. Because the `stat`
option no longer exists in `glob` v13, `mtimeMs` will be `undefined` for all entries,
causing the sorting logic to fail silently and produce an incorrectly ordered list of
files.
Did we get this right? 👍 / 👎 to inform future reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps the npm_and_yarn group with 11 updates in the / directory:
10.4.510.5.07.5.17.5.81.15.11.26.07.0.08.0.37.15.07.18.28.17.18.18.03.14.13.14.23.1.23.1.54.0.04.0.14.44.04.59.07.1.97.3.1Bumps the npm_and_yarn group with 1 update in the /packages/core directory: diff.
Updates
globfrom 10.4.5 to 10.5.0Commits
56774ef10.5.01e4e297bin: Do not expose filenames to shell expansionUpdates
tarfrom 7.5.1 to 7.5.8Commits
6b8eba07.5.82cb1120fix(unpack): improve UnpackSync symlink error "into" path accuracyd18e4e1fix: do not write linkpaths through symlinks4a37eb97.5.7f4a7aa9fix: properly sanitize hard links containing ..394ece67.5.67d4cc17fix race puting a Link ahead of its target File26ab9047.5.5e9a1ddbfix: do not prevent valid linkpaths within archive911c8867.5.4Maintainer changes
This version was pushed to npm by isaacs, a new releaser for tar since your current version.
Install script changes
This version adds
preparescript that runs during installation. Review the package contents before updating.Updates
@modelcontextprotocol/sdkfrom 1.15.1 to 1.26.0Release notes
Sourced from
@modelcontextprotocol/sdk's releases.... (truncated)
Commits
fe9c07bchore: bump version to 1.26.0 (#1479)4f01e7efix: add non-null assertions for optional setupServer fields in stateful testa05be17Merge commit from fork50d9fa3Fix #1430: Client Credentials providers scopes support (backported) (#1442)aa81a66fix(deps): resolve npm audit vulnerabilities and bump dependencies (v1.x back...6aba065chore: bump v1.25.3 for backport fixes (#1412)6e8f7e1fix: prevent Hono from overriding global Response object (v1.x) (#1411)12ae856[v1.x backport] Use correct schema for client sampling validation when tools ...b392f02fix: prevent ReDoS in UriTemplate regex patterns (v1.x backport) (#1365)a0c9b13fix: README badges links destinations (#907)Maintainer changes
This version was pushed to npm by pcarleton, a new releaser for
@modelcontextprotocol/sdksince your current version.Updates
difffrom 7.0.0 to 8.0.3Changelog
Sourced from diff's changelog.
Commits
13576bf8.0.3 release (#652)1179ccbIgnore .zed (#651)949d6e2Add test for the vuln I just fixed (#650)15a1585Fix the second denial-of-service vulnerability in parsePatch (#649)de95ccaFix potentially cubic-time regex in parsePatch (#647)b9aeedeAllow more customisation of file headers in patches (#641)43c716cMerge pull request #636 from kpdecker/dependabot/npm_and_yarn/node-forge-1.3.2b8162c7Bump node-forge from 1.3.1 to 1.3.2ad6dc17Fix some bugs in the diffWords regex (and errors & ambiguities in the comment...3e1774aFix a comment typo (#633)Updates
undicifrom 7.15.0 to 7.18.2Release notes
Sourced from undici's releases.
... (truncated)
Commits
7e5cb2dBumped v7.18.2 (#4730)b04e3cbfix(decompress): limit Content-Encoding chain to 5 to prevent resource exhaus...2bcb77bBumped v7.18.1 (#4728)58a12b7build(deps): bump actions/checkout from 6.0.0 to 6.0.1 (#4719)5fa2930build(deps): bump step-security/harden-runner from 2.13.1 to 2.14.0 (#4718)fbbe283docs: add security warning for strictContentLength option (#4726)ce12d9efix: do not crash if Node.js is compiled without SSL (#4727)ebe3e33Bumped v7.18.0 (#4725)4e9b88bfix: limit Content-Encoding chain to 5 to prevent resource exhaustiond560767Bumped v7.17.0 (#4724)Maintainer changes
This version was pushed to npm by [GitHub Actions](https://www.npmjs.com/~GitHub Actions), a new releaser for undici since your current version.
Updates
ajvfrom 8.17.1 to 8.18.0Release notes
Sourced from ajv's releases.
Commits
142ce848.18.0720a23ffix(pattern): use configured RegExp engine with $data keyword to mitigate ReD...82735a1fix: typos in schema-language.md (#2507)b17ec32fix: small grammatical error in managing-schemas.md (#2508)69568d0fix: #2482 Infinity and NaN serialise to null (#2487)f06766ffeat: allow tree-shaking by adding ``"sideEffects": falsetopackage.json` ...Updates
js-yamlfrom 3.14.1 to 3.14.2Changelog
Sourced from js-yaml's changelog.
... (truncated)
Commits
9963d363.14.2 released10d3c8edist rebuild5278870fix prototype pollution in merge (<<) (#731)Updates
minimatchfrom 3.1.2 to 3.1.5Commits
7bba9783.1.5bd25942docs: add warning about ReDoS1a9c27cfix partial matching of globstar patterns1a2e0843.1.4ae24656update lockfileb100374limit recursion for **, improve perf considerably26ffeaalockfile update9eca892lock node version to 1400c323b3.1.330486b2update CI matrix and actionsUpdates
jwsfrom 4.0.0 to 4.0.1Release notes
Sourced from jws's releases.
Changelog
Sourced from jws's changelog.
... (truncated)
Commits
34c45b2Merge commit from fork49bc39bversion 4.0.1d42350cEnhance tests for HMAC streaming sign and verify5cb007cImprove secretOrKey initialization in VerifyStreamf9a2e1cImprove secret handling in SignStreamb9fb8d3Merge pull request #102 from auth0/SRE-57-Upload-opslevel-yaml95b75eeUpload OpsLevel YAML8857ee7test: remove unused variable (#96)Maintainer changes
This version was pushed to npm by julien.wollscheid, a new releaser for jws since your current version.
Updates
rollupfrom 4.44.0 to 4.59.0Release notes
Sourced from rollup's releases.
... (truncated)
Changelog
Sourced from rollup's changelog.
... (truncated)
Commits
ae846954.59.0b39616eUpdate audit-resolvec60770dValidate bundle stays within output dir (#6275)33f39c14.58.0b61c408forward NO_SIDE_EFFECTS annotations to function expressions in variable decla...7f00689Extend agent instructionse7b2b85chore(deps): lock file maintenance (#6270)2aa5da9fix(deps): update minor/patch updates (#6267)4319837chore(deps): update dependency lru-cache to v11 (#6269)c3b6b4bchore(deps): update dependency eslint-plugin-unicorn to v63 (#6268)Maintainer changes
This version was pushed to npm by [GitHub Actions](https://www.npmjs.com/~GitHub Actions), a new releaser for rollup since your current version.
Install script changes
This version modifies
preparescript that runs during installation. Review the package contents before updating.Updates
vitefrom 7.1.9 to 7.3.1Release notes
Sourced from vite's releases.